From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] otg/ulpi.c : fix register write
Date: Sun, 27 Jun 2010 10:42:01 +0300 [thread overview]
Message-ID: <4C2700C9.2090602@compulab.co.il> (raw)
In-Reply-To: <4C236D9A.4030707@eukrea.com>
On 06/24/10 17:37, Eric B?nard wrote:
> Le 24/06/2010 16:04, Igor Grinberg a ?crit :
>> ulpi_set_flags is used to set the OTG flags and not to clear them,
>> also it is a static function and is not a part of struct
>> otg_transceiver,
>> so it cannot be called from outside the ulpi.c, thus after the
>> ulpi_create,
>> it is never called.
>> I think, currently, this should stay as it is.
>>
> OK, the problem that when one flag is set, you can't clear it without
> resetting the PHY.
This is correct, but current ulpi driver is not designed for writing
multiple times
into the ULPI_OTG_CTRL register, only once when ulpi_init function is
called.
Do you call the ulpi_init function for a couple of times? Looks like a hack.
>
> Eric
>
--
Regards,
Igor.
next prev parent reply other threads:[~2010-06-27 7:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 16:43 [PATCH v2] otg/ulpi.c : fix register write Eric Bénard
2010-06-24 14:04 ` Igor Grinberg
2010-06-24 14:37 ` Eric Bénard
2010-06-27 7:42 ` Igor Grinberg [this message]
2010-06-27 14:00 ` Eric Bénard
2010-07-06 10:31 ` Igor Grinberg
2010-07-14 14:22 ` Igor Grinberg
2010-07-14 20:47 ` Greg KH
2010-07-15 5:26 ` Igor Grinberg
2010-07-15 7:20 ` Eric Bénard
2010-07-21 14:46 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2700C9.2090602@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox