From: mcuelenaere@gmail•com (Maurus Cuelenaere)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5] libata: pata_samsung: Add Samsung PATA controller driver
Date: Wed, 30 Jun 2010 12:40:44 +0200 [thread overview]
Message-ID: <4C2B1F2C.9070705@gmail.com> (raw)
In-Reply-To: <016f01cb1840$850c4ae0$8f24e0a0$%kim@samsung.com>
Op 30-06-10 12:39, Kukjin Kim schreef:
> Maurus Cuelenaere wrote:
> Hi Maurus :-)
Hi Kukjin
>> Op 29-06-10 13:05, Kukjin Kim schreef:
>>> From: Abhilash Kesavan <a.kesavan@samsung•com>
>>>
>>> Adds support for the Samsung PATA controller. This driver is based on the
>>> Libata subsystem and references the earlier patches sent for IDE subsystem.
>>>
>>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung•com>
>>> Signed-off-by: Kukjin Kim <kgene.kim@samsung•com>
>>> Cc: Ben Dooks <ben-linux@fluff•org>
<snip>
>>> +/*
>>> + * Waits until the IDE controller is able to perform next read/write
>>> + * operation to the disk. Needed for 64XX series boards only.
>>> + */
>>> +static int wait_for_host_ready(struct s3c_ide_info *info)
>>> +{
>>> + ulong timeout;
>>> + void __iomem *fifo_reg = info->ide_addr + info->fifo_status_reg;
>>> +
>> Shouldn't this have an if (type != S3C64XX) return 0; ?
>>
> Actually, wait_for_host_ready() is called only by pata_s3c_port_ops methods
Oh, ok. Sorry for the noise.
--
Maurus Cuelenaere
next prev parent reply other threads:[~2010-06-30 10:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-29 11:05 [PATCH v5] libata: pata_samsung: Add Samsung PATA controller driver Kukjin Kim
2010-06-29 13:29 ` Juergen Schindele
2010-06-30 10:35 ` Kukjin Kim
2010-06-29 18:33 ` Maurus Cuelenaere
2010-06-30 10:39 ` Kukjin Kim
2010-06-30 10:40 ` Maurus Cuelenaere [this message]
2010-07-11 10:31 ` Sergei Shtylyov
2010-07-12 2:38 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2B1F2C.9070705@gmail.com \
--to=mcuelenaere@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox