Subject: [PATCH v3 08/12] s3c-fb: Add SHADOWCON shadow register locking support for S5PV210

From: [email-masked] (Ben Dooks)
Date: Fri, 02 Jul 2010 14:11:35 +0100

On 28/06/10 09:08, Pawel Osciak wrote:
> S5PV210 allows per-window locking of register value updates from shadow
> registers.
> 
> Signed-off-by: Pawel Osciak <[email-masked]>
> Signed-off-by: Kyungmin Park <[email-masked]>
> ---
>  arch/arm/plat-samsung/include/plat/regs-fb.h |    3 ++
>  drivers/video/s3c-fb.c                       |   39 +++++++++++++++++++++++--
>  2 files changed, 38 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/plat-samsung/include/plat/regs-fb.h b/arch/arm/plat-samsung/include/plat/regs-fb.h
> index 5bcdd09..da54b64 100644
> --- a/arch/arm/plat-samsung/include/plat/regs-fb.h
> +++ b/arch/arm/plat-samsung/include/plat/regs-fb.h
> @@ -218,6 +218,9 @@
>  #define WINCON1_BPPMODE_25BPP_A1888		(0xd << 2)
>  #define WINCON1_BPPMODE_28BPP_A4888		(0xd << 2)
>  
> +/* S5PV210 */
> +#define SHADOWCON				(0x34)
> +#define SHADOWCON_WINx_PROTECT(_win)		(1 << (10 + _win))

you should have () around the _win arg.

>  
>  #define VIDOSDxA_TOPLEFT_X_MASK			(0x7ff << 11)
>  #define VIDOSDxA_TOPLEFT_X_SHIFT		(11)
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 0a93fca..94423c5 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -79,6 +79,7 @@ struct s3c_fb;
>   * @osd: The base for the OSD registers.
>   * @palette: Address of palette memory, or 0 if none.
>   * @has_prtcon: Set if has PRTCON register.
> + * @has_shadowcon: Set if has SHADOWCON register.
>   */
>  struct s3c_fb_variant {
>  	unsigned int	is_2443:1;
> @@ -95,6 +96,7 @@ struct s3c_fb_variant {
>  	unsigned short	palette[S3C_FB_MAX_WIN];
>  
>  	unsigned int	has_prtcon:1;
> +	unsigned int	has_shadowcon:1;
>  };
>  
>  /**
> @@ -363,6 +365,36 @@ static int s3c_fb_align_word(unsigned int bpp, unsigned int pix)
>  }
>  
>  /**
> + * shadow_protect_win() - disable updating values from shadow registers at vsync
> + *
> + * @win: window to protect registers for
> + * @protect: 1 to protect (disable updates)
> + */
> +static void shadow_protect_win(struct s3c_fb_win *win, int protect)

technically, protect should be of type 'bool'/