From: philippe.langlais@stericsson•com (Philippe Langlais)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/6] U6715 clocks gating management U6 clock generic driver & U6715 cgu clock specific (V2)
Date: Mon, 5 Jul 2010 09:09:23 +0200 [thread overview]
Message-ID: <4C318523.1060706@stericsson.com> (raw)
In-Reply-To: <20100624141418.GB6523@n2100.arm.linux.org.uk>
Hi,
OK for all your remarks, we have changed our implementation to follow
the new one using clkdev.
The new patch will be sent today.
Regards
Philippe
On 06/24/10 16:14, Russell King - ARM Linux wrote:
> On Thu, May 27, 2010 at 10:27:28AM +0200, Philippe Langlais wrote:
>
>> +#if defined(DEBUG_CGU)
>> +#define debug(fmt, args...) \
>> + printk(PKMOD fmt, ## args)
>> +#else
>> +#define debug(fmt, args...)
>> +#endif
>>
> pr_debug?
>
>> +
>> +/**
>> + * U6 hw low level access clock functions
>> + **/
>> +static void u6_clk_disable(struct clk *clk);
>> +static int u6_clk_enable(struct clk *clk);
>> +
>> +/**
>> + * HW enable clock function.
>> + **/
>> +
>> +static int u67xx_cgu_enable_fake_clock(struct clk *clk)
>> +{
>> + debug("u67xx_cgu_enable_fake_clock for %s\n", clk->name);
>> + return 0;
>> +}
>> +
>> +static int u67xx_cgu_enable_hw_clock(struct clk *clk)
>> +{
>> + unsigned long value;
>> + debug("u67xx_cgu_enable_hw_clock for %s\n", clk->name);
>> +
>> + if (unlikely(clk->enable_reg == 0)) {
>>
> These are pointers. 0 is an integer. Use NULL. Check your code with
> sparse and you'll get warnings for these things.
>
>
>> +/*** Basic clocks ***/
>> +
>> +/* Base external input clocks */
>> +static struct clk func_32k_ck = {
>> + .name = "func_32k_ck",
>> + .rate = 32000,
>> + .flags = RATE_FIXED | ALWAYS_ENABLED,
>> + .usecount = 1,
>> +};
>>
> Don't put data definitions in header files.
>
>
>> +static struct clk *onchip_clks[] = {
>> + /* external root sources */
>> + &func_32k_ck,
>> + &osc_ck,
>> + &sys_ck,
>> + &sc_ck,
>> + &fix_ck,
>> + &tv_ck,
>> +#ifndef U6_OPTIMIZED_TREE
>> + &dsp2_ck,
>> +#endif
>> + &sdm_ck,
>> + &arm_ck,
>> + &hclk_ck,
>> + &hclk2_ck,
>> + &pclk1_ck,
>> + &pclk2_ck,
>> + &tvclk_ck,
>>
> This all looks very much like it was copied from the OMAP code as of about
> a year ago. The OMAP code has moved forwards with lots of improvements,
> including using clkdev to eliminate the disgusting SoC specific code from
> drivers (which clkdev is there to prevent.)
>
next prev parent reply other threads:[~2010-07-05 7:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 8:27 U6/U6715 ARM architecture files, 2nd try Philippe Langlais
2010-05-27 8:27 ` [PATCH 1/6] U6/U6715 ARM architecture files Philippe Langlais
2010-06-24 14:08 ` Russell King - ARM Linux
2010-06-25 13:34 ` Philippe Langlais
2010-05-27 8:27 ` [PATCH 2/6] U6715 clocks gating management U6 clock generic driver & U6715 cgu clock specific (V2) Philippe Langlais
2010-06-24 14:14 ` Russell King - ARM Linux
2010-07-05 7:09 ` Philippe Langlais [this message]
2010-05-27 8:27 ` [PATCH 3/6] U6715 gpio platform driver This driver is U6 platform generic (V2) Philippe Langlais
2010-06-24 14:26 ` Russell King - ARM Linux
2010-07-05 7:14 ` Philippe Langlais
2010-05-27 8:27 ` [PATCH 4/6] U6715 platform serial driver It's a generic driver for all U6 platform (V2) Philippe Langlais
2010-06-24 14:17 ` Russell King - ARM Linux
2010-05-27 8:27 ` [PATCH 5/6] U6715 8250 serial like driver Philippe Langlais
2010-06-24 14:31 ` Russell King - ARM Linux
2010-07-05 7:39 ` Philippe Langlais
2010-05-27 8:27 ` [PATCH 6/6] U6715 Default configuration for ST-Ericsson reference design boards Philippe Langlais
-- strict thread matches above, loose matches on Subject: below --
2010-04-28 7:32 U6/U6715 ARM architecture files, 1rst try Philippe Langlais
2010-04-28 7:32 ` [PATCH 2/6] U6715 clocks gating management U6 clock generic driver & U6715 cgu clock specific (V2) Philippe Langlais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C318523.1060706@stericsson.com \
--to=philippe.langlais@stericsson$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox