From: jy0922.shim@samsung•com (Joonyoung Shim)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 0/4] ARM: S5P: Support gpio interrupts
Date: Tue, 06 Jul 2010 16:40:17 +0900 [thread overview]
Message-ID: <4C32DDE1.8070906@samsung.com> (raw)
In-Reply-To: <000101cb1427$e88bfec0$b9a3fc40$%szyprowski@samsung.com>
On 6/25/2010 2:33 PM, Marek Szyprowski wrote:
> Hello,
>
> On Wednesday, June 23, 2010 9:51 AM Kukjin Kim wrote:
>
>> Joonyoung Shim wrote:
>>> This patch v2 set is to support gpio interrupts of samsung s5p cpus, and
>>> the GPIOlib gpio_to_irq goes to plat-samsung gpiolib, so patch v2 set
>>> has four commit smaller than v1.
>>>
>>> Changes since v1:
>>> - Add irq_base to s3c_gpio_chip struct
>>> - GPIOlib gpio_to_irq() is implemented to samsung_gpiolib_to_irq() of
>>> plat-samsung gpiolib
>>>
>>> Joonyoung Shim (4):
>>> ARM: S5PV210: Add gpio interrupt support
>>> ARM: S5PC100: Use S5P gpio interrupts interface
>>> ARM: S5PC100: Move external interrupt defines
>>> ARM: SAMSUNG: Add GPIOlib gpio_to_irq
>>>
>>> arch/arm/mach-s5pc100/Makefile | 2 +-
>>> arch/arm/mach-s5pc100/gpiolib.c | 70 ++-----
>>> arch/arm/mach-s5pc100/include/mach/gpio.h | 7 -
>>> arch/arm/mach-s5pc100/include/mach/irqs.h | 18 ++-
>>> arch/arm/mach-s5pc100/include/mach/regs-gpio.h | 7 +
>>> arch/arm/mach-s5pc100/irq-gpio.c | 266
>> ------------------------
>>> arch/arm/mach-s5pv210/gpiolib.c | 18 ++-
>>> arch/arm/mach-s5pv210/include/mach/irqs.h | 16 ++-
>>> arch/arm/plat-s5p/Makefile | 2 +-
>>> arch/arm/plat-s5p/irq-gpioint.c | 208 ++++++++++++++++++
>>> arch/arm/plat-samsung/gpiolib.c | 9 +
>>> arch/arm/plat-samsung/include/plat/gpio-core.h | 6 +
>>> 12 files changed, 295 insertions(+), 334 deletions(-)
>>> delete mode 100644 arch/arm/mach-s5pc100/irq-gpio.c
>>> create mode 100644 arch/arm/plat-s5p/irq-gpioint.c
>>>
>> I am sure this patchset is working code, but Ben had made suggestion about
>> 'sparse irq'...
>> It is because there are too many gpio interrupts and having support of all
>> of them is unnecessary as realistically only few of them maybe used.
>
> Right. Ben suggested to create a pool for gpio interrupts (for example 16
> interrupts) and selectively assign them in machine startup code to those
> gpio pins that really need it.
>
> The problem is that such solution is not yet ready and we really need the
> gpio interrupt functionality for our boards (Aquila and GONI).
>
> Maybe these current patches could be merged now, and then, once the new
> solution is prepared, the gpio interrupt support get converted to selective
> registering?
>
I agree with Marek.
Ben and Kukjin, how do you think about this?
> S5PC100 already has gpio interrupt support.
>
>> In fact in SMDK board there is no use of gpio in interrupt mode.
>
> We are talking about support for Samsung S5PV210/S5PC110 SoCs in the Linux
> mainline kernel, not the support for only SMDK boards. GPIO interrupts is
> a feature of the SoC not a particular board.
>
> Best regards
> --
> Marek Szyprowski
> Samsung Poland R&D Center
>
>
prev parent reply other threads:[~2010-07-06 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 8:33 [PATCH v2 0/4] ARM: S5P: Support gpio interrupts Joonyoung Shim
2010-06-23 7:50 ` Kukjin Kim
2010-06-23 13:36 ` Kyungmin Park
2010-06-25 5:33 ` Marek Szyprowski
2010-07-06 7:40 ` Joonyoung Shim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C32DDE1.8070906@samsung.com \
--to=jy0922.shim@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox