From: viresh.kumar@st•com (Viresh KUMAR)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4] GPIO PL061: Adding Clk framework support
Date: Mon, 12 Jul 2010 09:37:43 +0530 [thread overview]
Message-ID: <4C3A950F.5040900@st.com> (raw)
In-Reply-To: <20100709124050.GF22845@n2100.arm.linux.org.uk>
On 7/9/2010 6:10 PM, Russell King - ARM Linux wrote:
> On Tue, Jun 22, 2010 at 10:37:27AM +0530, Viresh KUMAR wrote:
>> - spin_lock_init(&chip->lock);
>> - spin_lock_init(&chip->irq_lock);
>> - INIT_LIST_HEAD(&chip->list);
>> + chip->clk = clk_get(&dev->dev, NULL);
>> + if (IS_ERR(chip->clk)) {
>> + ret = PTR_ERR(chip->clk);
>> + /* clk Not present */
>> + if (ret == -ENOENT)
>> + chip->clk = NULL;
>
> Please don't assume that NULL is not a valid value for a 'struct clk'.
> Eg,
>
> struct clk *clk_get(struct device *dev, const char *id)
> {
> return dev && strcmp(dev_name(dev), "mb:16") == 0 ? NULL : ERR_PTR(-ENOENT);
> }
I knew this. This convention is just local to the driver.
>
> However, this patch begs the question about what you're trying to do,
> as the primecell doesn't take a clock for its operation other than the
> AMBA bus clock.
This issue is different from the issue i raised which was common to
all amba devices. This is just for this GPIO driver, we need to enable clk
before using any gpio pin.
viresh.
next prev parent reply other threads:[~2010-07-12 4:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 5:07 [PATCH v4] GPIO PL061: Adding Clk framework support Viresh KUMAR
2010-06-22 17:06 ` Baruch Siach
2010-07-09 12:40 ` Russell King - ARM Linux
2010-07-09 23:55 ` Linus Walleij
2010-07-10 7:19 ` Russell King - ARM Linux
2010-07-10 7:30 ` Russell King - ARM Linux
2010-07-10 15:36 ` Linus Walleij
2010-07-13 7:44 ` Russell King - ARM Linux
2010-07-13 11:00 ` Linus Walleij
2010-07-13 18:26 ` Russell King - ARM Linux
2010-07-15 6:02 ` Viresh KUMAR
2010-07-15 8:30 ` Russell King - ARM Linux
2010-07-15 9:35 ` Viresh KUMAR
2010-07-15 9:44 ` Linus Walleij
2010-07-15 9:56 ` Russell King - ARM Linux
2010-07-15 16:09 ` Rabin Vincent
2010-07-15 16:22 ` Russell King - ARM Linux
2010-07-29 23:22 ` Kevin Wells
2010-07-30 7:09 ` Russell King - ARM Linux
2010-08-03 0:40 ` Kevin Wells
2010-08-03 13:00 ` Linus Walleij
2010-08-03 20:36 ` Kevin Wells
2010-08-03 21:23 ` Russell King - ARM Linux
2010-07-30 15:19 ` Linus Walleij
2010-07-12 4:07 ` Viresh KUMAR [this message]
2010-07-12 7:53 ` Linus Walleij
2010-07-12 8:07 ` Russell King - ARM Linux
2010-07-12 8:18 ` Viresh KUMAR
2010-07-12 8:34 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3A950F.5040900@st.com \
--to=viresh.kumar@st$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox