From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/5] cpufreq-pxa3xx: use HSIO 312MHz on the pxa310
Date: Mon, 12 Jul 2010 13:20:22 +0300 [thread overview]
Message-ID: <4C3AEC66.4090907@compulab.co.il> (raw)
In-Reply-To: <AANLkTinI5mJZfQm_Ewd7qShSkB3jlsdJIiiA_W1E2F0s@mail.gmail.com>
On 07/12/10 12:29, Eric Miao wrote:
> On Mon, Jul 12, 2010 at 5:13 PM, Igor Grinberg <grinberg@compulab•co.il> wrote:
>
>>
>> On 07/12/10 11:37, pieterg wrote:
>>
>>> On Sunday 11 July 2010 09:14:22 Igor Grinberg wrote:
>>>
>>>
>>>> On 07/09/10 11:31, pieterg wrote:
>>>>
>>>>
>>>>> On Friday 09 July 2010 10:02:16 Eric Miao wrote:
>>>>>
>>>>>
>>>>>> What's wrong with 208MHz HSS on PXA310?
>>>>>>
>>>>>>
>>>>> I haven't done any benchmarking, but Marvell found it worth to
>>>>> introduce 312MHz for the pxa310. (I assume it might have something to
>>>>> do with the video accelerator, which is unique to the pxa310).
>>>>>
>>>>> And to me it makes sense to use the highest supported speeds in the top
>>>>> cpufreq entry.
>>>>>
>>>>>
>>>> According to Marvell's PXA3xx Specification Update document
>>>> (page 68 - SCr#3), the above is correct starting from silicon revision
>>>> A2. What about earlier revisions? Shouldn't we support all of them?
>>>>
>>>>
>>> OK, I missed that. In that case we should leave this one out.
>>>
>>>
>> If you really want this to go, you can check the cpu stepping (cpuid
>> register)
>> and fixup the table accordingly. Something like:
>>
>> if (cpu_is_pxa310())
>> ret = setup_freqs_table(policy, (read_cpuid_id() & 0xf) ?
>>
>> ARRAY_AND_SIZE(pxa310_freqs) :
>>
>> ARRAY_AND_SIZE(pxa300_freqs));
>>
>> but I don't know if Eric will like it ;)
>>
>>
> Nah, I was thinking of introducing a cpu_is_pxa310_a2() or something,
> but that's really hard to make generic, since for this case, we'd
> have to use cpu_is_pxa310_a2_or_above(), which is #!$!%!@#$
>
> So to put it simple, I think a command line parameter would make
> more sense in this case. e.g. pxa310_use_312mhz.
>
Indeed, command line parameter pxa310.hss=312/208 sounds good
>
>>> Rgds, Pieter
>>>
>>>
>>>
>> --
>> Regards,
>> Igor.
>>
>>
>>
>
--
Regards,
Igor.
prev parent reply other threads:[~2010-07-12 10:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-08 17:04 [PATCH 1/5] cpufreq-pxa3xx: use HSIO 312MHz on the pxa310 pieterg
2010-07-09 8:02 ` Eric Miao
2010-07-09 8:31 ` pieterg
2010-07-11 7:14 ` Igor Grinberg
2010-07-12 8:37 ` pieterg
2010-07-12 9:13 ` Igor Grinberg
2010-07-12 9:29 ` Eric Miao
2010-07-12 10:20 ` Igor Grinberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3AEC66.4090907@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox