From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] otg/ulpi.c : fix register write
Date: Wed, 14 Jul 2010 17:22:59 +0300 [thread overview]
Message-ID: <4C3DC843.7060502@compulab.co.il> (raw)
In-Reply-To: <1277311435-12027-1-git-send-email-eric@eukrea.com>
Greg,
I have a patch set, I want to submit in the very near future and it
relies on this one.
Will this patch get to your tree?
> ulpi_set_vbus and ulpi_set_flags are using ULPI_SET(register) to write
> to the PHY's registers, which means we can only set bits in the PHY's
> register and not clear them.
> By directly using the address of the register without any offset, we
> now get the expected behaviour for these functions.
>
> Signed-off-by: Eric B?nard <eric@eukrea•com>
> Cc: Daniel Mack <daniel@caiaq•de>
> Cc: linux-usb at vger.kernel.org
> Cc: linux-arm-kernel at lists.infradead.org
> Cc: Sascha Hauer <kernel@pengutronix•de>
> ---
> v2 :
> drop reg/val swap which is handled in a better way by Igor's patch here :
> http://comments.gmane.org/gmane.linux.usb.general/32092
>
> drivers/usb/otg/ulpi.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/otg/ulpi.c b/drivers/usb/otg/ulpi.c
> index b1b3469..086853b 100644
> --- a/drivers/usb/otg/ulpi.c
> +++ b/drivers/usb/otg/ulpi.c
> @@ -54,7 +54,7 @@ static int ulpi_set_flags(struct otg_transceiver *otg)
> if (otg->flags & USB_OTG_EXT_VBUS_INDICATOR)
> flags |= ULPI_OTG_CTRL_EXTVBUSIND;
>
> - return otg_io_write(otg, flags, ULPI_SET(ULPI_OTG_CTRL));
> + return otg_io_write(otg, flags, ULPI_OTG_CTRL);
> }
>
> static int ulpi_init(struct otg_transceiver *otg)
> @@ -90,7 +90,7 @@ static int ulpi_set_vbus(struct otg_transceiver *otg, bool on)
> flags |= ULPI_OTG_CTRL_DRVVBUS_EXT;
> }
>
> - return otg_io_write(otg, flags, ULPI_SET(ULPI_OTG_CTRL));
> + return otg_io_write(otg, flags, ULPI_OTG_CTRL);
> }
>
> struct otg_transceiver *
>
--
Regards,
Igor.
next prev parent reply other threads:[~2010-07-14 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-23 16:43 [PATCH v2] otg/ulpi.c : fix register write Eric Bénard
2010-06-24 14:04 ` Igor Grinberg
2010-06-24 14:37 ` Eric Bénard
2010-06-27 7:42 ` Igor Grinberg
2010-06-27 14:00 ` Eric Bénard
2010-07-06 10:31 ` Igor Grinberg
2010-07-14 14:22 ` Igor Grinberg [this message]
2010-07-14 20:47 ` Greg KH
2010-07-15 5:26 ` Igor Grinberg
2010-07-15 7:20 ` Eric Bénard
2010-07-21 14:46 ` Igor Grinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3DC843.7060502@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox