From: ryan@bluewatersys•com (Ryan Mallon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/3] usb/host || arch/arm: Remove dead CONFIG_ARCH_KARO
Date: Thu, 15 Jul 2010 08:58:06 +1200 [thread overview]
Message-ID: <4C3E24DE.7050208@bluewatersys.com> (raw)
In-Reply-To: <9df7166bb950e7fbc12d1be9f2b9f9cbb9961187.1279104996.git.qy03fugy@stud.informatik.uni-erlangen.de>
On 07/14/2010 11:32 PM, Christian Dietrich wrote:
> CONFIG_ARCH_KARO doesn't exist in Kconfig and is never defined anywhere
> else, therefore removing all references for it from the source code.
>
> Signed-off-by: Christian Dietrich <qy03fugy@stud•informatik.uni-erlangen.de>
> ---
> arch/arm/tools/mach-types | 1 -
> drivers/usb/host/isp1362.h | 24 +-----------------------
> 2 files changed, 1 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm/tools/mach-types b/arch/arm/tools/mach-types
> index 8f10d24..3d86318 100644
> --- a/arch/arm/tools/mach-types
> +++ b/arch/arm/tools/mach-types
> @@ -204,7 +204,6 @@ omaha ARCH_OMAHA OMAHA 186
> ta7 ARCH_TA7 TA7 187
> nova SA1100_NOVA NOVA 188
> hmk ARCH_HMK HMK 189
> -karo ARCH_KARO KARO 190
> fester SA1100_FESTER FESTER 191
> gpi ARCH_GPI GPI 192
> smdk2410 ARCH_SMDK2410 SMDK2410 193
Don't post patches for the mach-types file. It is generated
automatically from here the ARM machine registry:
http://www.arm.linux.org.uk/developer/machines/.
It is perfectly fine to have a machine type defined in mach-types which
is not supported in the mainline kernel. This allows developers to have
a stable machine id even if their board is not yet supported in the
mainline kernel.
> diff --git a/drivers/usb/host/isp1362.h b/drivers/usb/host/isp1362.h
> index d995351..0f97820 100644
> --- a/drivers/usb/host/isp1362.h
> +++ b/drivers/usb/host/isp1362.h
> @@ -8,29 +8,7 @@
> /*
> * Platform specific compile time options
> */
> -#if defined(CONFIG_ARCH_KARO)
> -#include <asm/arch/hardware.h>
> -#include <asm/arch/pxa-regs.h>
> -#include <asm/arch/karo.h>
> -
> -#define USE_32BIT 1
> -
> -
> -/* These options are mutually eclusive */
> -#define USE_PLATFORM_DELAY 1
> -#define USE_NDELAY 0
> -/*
> - * MAX_ROOT_PORTS: Number of downstream ports
> - *
> - * The chip has two USB ports, one of which can be configured as
> - * an USB device port, so the value of this constant is implementation
> - * specific.
> - */
> -#define MAX_ROOT_PORTS 2
> -#define DUMMY_DELAY_ACCESS do {} while (0)
> -
> -/* insert platform specific definitions for other machines here */
> -#elif defined(CONFIG_BLACKFIN)
> +#if defined(CONFIG_BLACKFIN)
>
> #include <linux/io.h>
> #define USE_32BIT 0
The rest of this patch looks fine. It appears the Karo stuff was added
when the ISP1362 driver was first committed. Probably some left over
development stuff that got missed.
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2010-07-14 20:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 11:31 [PATCH 0/3] Removing dead code Christian Dietrich
2010-07-14 11:32 ` [PATCH 2/3] usb/{gadget,host}: Remove dead CONFIG_CPU_PXA27x Christian Dietrich
2010-07-14 12:30 ` Eric Miao
2010-07-15 9:38 ` Eric Miao
2010-07-14 11:32 ` [PATCH 3/3] usb/host || arch/arm: Remove dead CONFIG_ARCH_KARO Christian Dietrich
2010-07-14 13:35 ` Mike Frysinger
2010-07-14 20:58 ` Ryan Mallon [this message]
2010-07-20 7:08 ` [PATCH] usb/host: " Christian Dietrich
2010-07-20 20:56 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C3E24DE.7050208@bluewatersys.com \
--to=ryan@bluewatersys$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox