From: philippe.langlais@stericsson•com (Philippe Langlais)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/6] U6/U6715 ARM architecture files
Date: Fri, 16 Jul 2010 15:04:13 +0200 [thread overview]
Message-ID: <4C4058CD.3020303@stericsson.com> (raw)
In-Reply-To: <20100715111746.GA29322@n2100.arm.linux.org.uk>
Hi,
On 07/15/10 13:17, Russell King - ARM Linux wrote:
> Sorry, there's a few more points here.
>
>
Never mind
> On Fri, Jul 09, 2010 at 05:21:48PM +0200, Philippe Langlais wrote:
>
>> diff --git a/arch/arm/mach-u67xx/Kconfig b/arch/arm/mach-u67xx/Kconfig
>> new file mode 100644
>> index 0000000..48f53fb
>> --- /dev/null
>> +++ b/arch/arm/mach-u67xx/Kconfig
>> @@ -0,0 +1,11 @@
>> +comment "U67XX Board Type"
>> + depends on ARCH_U67XX
>> +
>> +choice
>> + prompt "Choose the U67XX Board type"
>> + default MACH_U67XX_WAVEC_2GB
>> + help
>> + "Choose the ST-Ericsson Reference Design Board"
>> + config MACH_U67XX_WAVEC_2GB
>> + bool "U67XX WaveC Board with 2Gb Micron combo"
>>
> I thought convention here was to have the "config" statements all starting
> on column 1, and a blank line after 'help'. help shouldn't need the text
> quoted.
>
>
OK
>> diff --git a/arch/arm/plat-u6xxx/Kconfig b/arch/arm/plat-u6xxx/Kconfig
>> new file mode 100644
>> index 0000000..b01f77c
>> --- /dev/null
>> +++ b/arch/arm/plat-u6xxx/Kconfig
>> @@ -0,0 +1,20 @@
>> +menu "STE U6XXX Implementations"
>> +
>> +choice
>> + prompt "U67XX System Type"
>> + default ARCH_U67XX
>> +
>> +config ARCH_U67XX
>> + bool "U67XX"
>> + select PLAT_U6XXX
>> + select CPU_ARM926T
>> + select GENERIC_TIME
>> + select GENERIC_CLOCKEVENTS
>> + select U6_MTU_TIMER
>> +endchoice
>>
> ...
>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index cf30fc9..7045a05 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -739,6 +739,13 @@ config ARCH_U300
>> help
>> Support for ST-Ericsson U300 series mobile platforms.
>>
>> +config PLAT_U6XXX
>> + bool "ST-Ericsson U6XXX Series"
>> + select GENERIC_GPIO
>> + select ARCH_REQUIRE_GPIOLIB
>> + help
>> + Support for ST-Ericsson's U6XXX architecture
>> +
>> config ARCH_U8500
>> bool "ST-Ericsson U8500 Series"
>> select CPU_V7
>>
> Hmm. So, we have PLAT_U6XXX to select support for the U6XXX platform
> series on the main machine class menu. We then have a globally visible
> ARCH_U67XX option, which selects PLAT_U6XXX, and that then gives us a
> MACH_U67XX_WAVEC_2GB option.
>
> This seems to be rather obsure - what if I have some other machine class
> selected, and I enable ARCH_U67XX ?
>
> How about having ARCH_U67XX in the main machine class menu, which allows
> us to see MACH_U67XX_WAVEC_2GB. When MACH_U67XX_WAVEC_2GB is enabled,
> this selects PLAT_U6XXX to pick up the plat-* stuff?
>
>
You're right, I fix that.
>> +static inline void arch_reset(char mode, const char *cmd)
>> +{
>> + unsigned long flags;
>> + /*
>> + * To reset, we hit the on-board reset register
>> + * in the system FPGA
>> + */
>> + /* diasble HW interruption */
>> + raw_local_irq_save(flags);
>> + /* load watchdog with reset value */
>> + outl(0x5, IO_ADDRESS(WDRU_BASE + WDRU_TIM_OFFSET));
>>
> s/outl/writel/ please.
>
OK
>
>> diff --git a/arch/arm/plat-u6xxx/include/mach/uncompress.h b/arch/arm/plat-u6xxx/include/mach/uncompress.h
>> new file mode 100644
>> index 0000000..7dae14d
>> --- /dev/null
>> +++ b/arch/arm/plat-u6xxx/include/mach/uncompress.h
>>
> ...
>
>> +static void putc(int c)
>> +{
>> + if (c == '\n')
>> + putc('\r');
>>
> Hmm, so you want to output \r\r\n for each \n in the output stream?
>
I removed these lines.
>
>> diff --git a/arch/arm/plat-u6xxx/timer.c b/arch/arm/plat-u6xxx/timer.c
>> new file mode 100644
>> index 0000000..90464b1
>> --- /dev/null
>> +++ b/arch/arm/plat-u6xxx/timer.c
>>
> ...
>
>> +struct mmtu_ctxt {
>> + unsigned long *base;
>>
> __iomem ?
>
Yes
>
>> + int autoreload;
>>
> Is this a write-only variable? I couldn't find anything which reads it.
>
>
OK, it's a relicat of auto reload precedent implementation.
>> + uint32_t compvalue;
>> + uint32_t endvalue;
>> + struct clk *clk;
>> + int mode;
>> +};
>>
> ...
>
>> + case CLOCK_EVT_MODE_SHUTDOWN:
>> + mmtu->autoreload = 0;
>> +
>> + if (mmtu->clk == NULL) {
>> + mmtu->clk = clk_get(0, "MMTU");
>>
> clk_get(NULL, "MMTU")
>
OK
>
>> +struct sys_timer u6_timer = {
>> + .init = u6_timer_init,
>> +#ifndef CONFIG_GENERIC_TIME
>> + .offset = NULL,
>> +#endif
>>
> There's no need to initialize .offset, so this ifdef and initializer can
> be removed entirely.
>
OK
A new U6 arch patch will be sent very soon.
Regards,
Philippe
next prev parent reply other threads:[~2010-07-16 13:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 15:21 The first 3 patches for U6715 after review Philippe Langlais
2010-07-09 15:21 ` [PATCH 1/6] U6/U6715 ARM architecture files Philippe Langlais
2010-07-15 11:17 ` Russell King - ARM Linux
2010-07-16 13:04 ` Philippe Langlais [this message]
2010-07-09 15:21 ` [PATCH 2/6] U6715 clocks gating management U6 clock generic driver & U6715 cgu clock specific Philippe Langlais
2010-07-15 11:27 ` Russell King - ARM Linux
2010-07-19 8:34 ` Vincent GUITTOT
2010-07-09 15:21 ` [PATCH 3/6] U6715 gpio platform driver This driver is U6XXX platform generic Philippe Langlais
2010-07-15 11:18 ` Russell King - ARM Linux
2010-07-16 13:09 ` Philippe Langlais
-- strict thread matches above, loose matches on Subject: below --
2010-05-27 8:27 U6/U6715 ARM architecture files, 2nd try Philippe Langlais
2010-05-27 8:27 ` [PATCH 1/6] U6/U6715 ARM architecture files Philippe Langlais
2010-06-24 14:08 ` Russell King - ARM Linux
2010-06-25 13:34 ` Philippe Langlais
2010-04-28 7:32 U6/U6715 ARM architecture files, 1rst try Philippe Langlais
2010-04-28 7:32 ` [PATCH 1/6] U6/U6715 ARM architecture files Philippe Langlais
2010-05-06 13:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C4058CD.3020303@stericsson.com \
--to=philippe.langlais@stericsson$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox