public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: ben@simtec•co.uk (Ben Dooks)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: S5PV210: Add audio support to Aquila
Date: Thu, 29 Jul 2010 23:48:26 +0100	[thread overview]
Message-ID: <4C52053A.8090400@simtec.co.uk> (raw)
In-Reply-To: <4C4F9E4C.7000001@samsung.com>

On 28/07/10 04:04, Chanwoo Choi wrote:

[snip]


> +/* GPIO I2C AP 1.8V */
> +#define AP_I2C_GPIO_BUS_5	5
> +static struct i2c_gpio_platform_data i2c_gpio5_data = {
> +	.sda_pin	= S5PV210_MP05(3),	/* XM0ADDR_11 */
> +	.scl_pin	= S5PV210_MP05(2),	/* XM0ADDR_10 */
> +};
> +
> +static struct platform_device i2c_gpio5 = {
> +	.name		= "i2c-gpio",
> +	.id		= AP_I2C_GPIO_BUS_5,
> +	.dev		= {
> +		.platform_data	= &i2c_gpio5_data,
> +	},
> +};
> +
> +static struct i2c_board_info i2c_gpio5_devs[] __initdata = {
> +	{
> +		/* CS/ADDR = low 0x34 (FYI: high = 0x36) */
> +		I2C_BOARD_INFO("wm8994", 0x34 >> 1),
> +		.platform_data	= &wm8994_platform_data,
> +	},
> +};
> +
> +static void __init aquila_sound_init(void)
> +{
> +	unsigned int gpio;
> +
> +	/* CODEC_XTAL_EN */
> +	gpio = S5PV210_GPH3(2);		/* XEINT_26 */
> +	gpio_request(gpio, "CODEC_XTAL_EN");
> +	s3c_gpio_cfgpin(gpio, S3C_GPIO_OUTPUT);
> +	s3c_gpio_setpull(gpio, S3C_GPIO_PULL_NONE);
> +	gpio_direction_output(gpio, 1);

gpio_direction_output() should have done the cfgpin()
call.

> +	/* CLKOUT[9:8] set to 0x3(XUSBXTI) of 0xE010E000(OTHERS)
> +	 * for 24MHZ
> +	 */
> +	writel(readl(S5P_OTHERS) | (0x3 << 8), S5P_OTHERS);

Not sure if this should be being done directly? will it affect
the current clock tree?

  parent reply	other threads:[~2010-07-29 22:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-28  3:04 [PATCH 1/2] ARM: S5PV210: Add audio support to Aquila Chanwoo Choi
2010-07-29 17:38 ` Mark Brown
2010-07-30  7:15   ` Chanwoo Choi
2010-07-30  7:34     ` MyungJoo Ham
2010-08-03  8:59     ` Mark Brown
2010-08-04  6:16       ` [alsa-devel] " Chanwoo Choi
2010-08-04  8:19         ` Mark Brown
2010-09-29 12:16     ` Kukjin Kim
2010-09-30  1:23       ` Chanwoo Choi
2010-09-30  1:50         ` Kukjin Kim
2010-09-30  4:55           ` Chanwoo Choi
2010-07-29 22:48 ` Ben Dooks [this message]
2010-07-30  0:14   ` Kyungmin Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C52053A.8090400@simtec.co.uk \
    --to=ben@simtec$(echo .)co.uk \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox