From: tanmay.upadhyay@einfochips•com (Tanmay Upadhyay)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2] OpenRD: Enable SD/UART selection for serial port 1
Date: Tue, 10 Aug 2010 10:27:15 -0000 [thread overview]
Message-ID: <4C612856.6090405@einfochips.com> (raw)
In-Reply-To: <20100810085821.GF21175@chipmunk>
On 08/10/2010 02:28 PM, Alexander Clouter wrote:
> Hi,
>
> Just a quick amendment;
>
> * Alexander Clouter<alex@digriz•org.uk> [2010-08-10 09:56:43+0100]:
>
>> * Tanmay Upadhyay<tanmay.upadhyay@einfochips•com> [2010-08-10 13:59:33+0530]:
>>
>>> This patch enables user to use serial port 1 of the OpenRD device for SDIO
>>> or UART(RS232/RS485). The selection can be done through kernel parameter.
>>>
>>> By default the port would be used for SDIO. To select RS232 or RS485 mode,
>>> pass string "uart=232" or "uart=485" respectively in the kernel parameters.
>>> "uart=485" is ignored on OpenRD-Base as it doesn't have RS485 port.
>>>
>>> Signed-off-by: Tanmay Upadhyay<tanmay.upadhyay@einfochips•com>
>>> ---
>>> arch/arm/mach-kirkwood/openrd-setup.c | 92 ++++++++++++++++++++++++++++++++-
>>> 1 files changed, 91 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-kirkwood/openrd-setup.c b/arch/arm/mach-kirkwood/openrd-setup.c
>>> index fd06be6..cd061ab 100644
>>> --- a/arch/arm/mach-kirkwood/openrd-setup.c
>>> +++ b/arch/arm/mach-kirkwood/openrd-setup.c
>>> @@ -19,6 +19,7 @@
>>> #include<asm/mach-types.h>
>>> #include<asm/mach/arch.h>
>>> #include<mach/kirkwood.h>
>>> +#include<mach/gpio.h>
>>> #include<plat/mvsdio.h>
>>> #include "common.h"
>>> #include "mpp.h"
>>> @@ -57,7 +58,15 @@ static struct mvsdio_platform_data openrd_mvsdio_data = {
>>> };
>>>
>>> static unsigned int openrd_mpp_config[] __initdata = {
>>> + MPP12_SD_CLK,
>>> + MPP13_SD_CMD,
>>> + MPP14_SD_D0,
>>> + MPP15_SD_D1,
>>> + MPP16_SD_D2,
>>> + MPP17_SD_D3,
>>> + MPP28_GPIO,
>>> MPP29_GPIO,
>>> + MPP34_GPIO,
>>> 0
>>> };
>>>
>>> @@ -67,6 +76,71 @@ static struct i2c_board_info i2c_board_info[] __initdata = {
>>> },
>>> };
>>>
>>> +static int __initdata uart1;
>>>
>>
> static int __initdata uart1 = -EINVAL;
>
>
>>> +
>>> +static int __init sd_uart_selection(char *str)
>>> +{
>>> + /* Default is SD. Change if required, for UART */
>>> + if (!str)
>>> + return 0;
>>> +
>>> + if (!strncmp(str, "232", 3)) {
>>> + uart1 = 232;
>>> + } else if (!strncmp(str, "485", 3)) {
>>> + /* OpenRD-Base doesn't have RS485. Treat is as an
>>> + * unknown argument& just have default setting -
>>> + * which is SD */
>>> + if (machine_is_openrd_base())
>>> + return 1;
>>> +
>>>
>>>
>> uart1 = -ENODEV;
>> return 1;
>>
>>
>>> + uart1 = 485;
>>> + }
>>> + return 1;
>>>
>>>
>> uart1 = -EINVAL;
>> return 1;
>>
>>
> Drop this suggested amendment.
>
> Cheers
>
>
Intention here is to provide SD support by default. It will be switched
to UART mode only if someone asks to do so via kernel parameter. If
someone doesn't give OR gives improper kernel parameter, he/she won't
get UART1. It will simply fall-back to the default setting - which is SD
support.
Does this make sense? Please suggest.
Thanks,
Tanmay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20100810/d3ec9071/attachment-0001.html>
next prev parent reply other threads:[~2010-08-10 10:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <no>
2010-08-10 8:29 ` [PATCH v2] OpenRD: Enable SD/UART selection for serial port 1 Tanmay Upadhyay
2010-08-10 8:56 ` Alexander Clouter
2010-08-10 8:58 ` Alexander Clouter
2010-08-10 10:27 ` Tanmay Upadhyay [this message]
2010-08-10 10:28 ` Alexander Clouter
2010-08-10 10:49 ` Tanmay Upadhyay
2010-08-10 11:53 ` Alexander Clouter
2010-08-11 5:21 ` Tanmay Upadhyay
2010-08-10 8:40 ` [PATCH] ARM: Fix broken Kconfig in arch/arm Tanmay Upadhyay
2011-04-18 15:06 ` [v2 0/7] OMAP: GPIO: Use PM runtime framework Varadarajan, Charulatha
2011-04-19 6:26 ` Tony Lindgren
2011-04-20 23:59 ` Kevin Hilman
2011-04-21 5:42 ` Tony Lindgren
2011-04-21 15:15 ` Kevin Hilman
2011-04-22 6:11 ` Tony Lindgren
2011-04-23 8:35 ` Linus Walleij
2011-04-26 7:29 ` Tony Lindgren
2011-04-27 13:18 ` Linus Walleij
2011-05-03 16:22 ` Kevin Hilman
2011-05-03 21:41 ` Linus Walleij
2011-05-04 6:19 ` Tony Lindgren
2011-05-12 0:57 ` Linus Walleij
2011-05-12 9:42 ` Kevin Hilman
2011-05-19 19:08 ` Grant Likely
2011-05-20 3:34 ` Shawn Guo
2011-05-19 19:05 ` Grant Likely
2011-04-18 15:06 ` [PATCH 1/7] OMAP: GPIO: Make gpio_context part of gpio_bank structure Varadarajan, Charulatha
2011-04-18 15:06 ` [PATCH 2/7] OMAP: GPIO: Use flag to identify wkup dmn GPIO Varadarajan, Charulatha
2011-04-18 15:06 ` [PATCH 3/7] OMAP4: GPIO: Save/restore context Varadarajan, Charulatha
2011-04-21 0:26 ` Kevin Hilman
2011-04-18 15:06 ` [PATCH 4/7] OMAP: GPIO: handle save/restore ctx in GPIO driver Varadarajan, Charulatha
2011-04-18 15:06 ` [PATCH 5/7] OMAP2+: GPIO: make workaround_enabled bank specific Varadarajan, Charulatha
2011-04-18 15:06 ` [PATCH 6/7] OMAP: GPIO: Cleanup prepare_for_idle/resume Varadarajan, Charulatha
2011-04-18 15:06 ` [PATCH 7/7] OMAP: GPIO: use PM runtime framework Varadarajan, Charulatha
2011-07-14 9:37 ` [PATCH 1/2] ARM: pxa168: gplugD: Get rid of mfp-gplugd.h Tanmay Upadhyay
2011-07-18 6:00 ` Eric Miao
2011-07-14 9:37 ` [PATCH 2/2] ARM: pxa168: gplugD: bug-fix: Free correct GPIO Tanmay Upadhyay
2011-07-18 5:59 ` Eric Miao
2011-12-06 11:07 ` [PATCH] USB: pxa168: Fix compilation error Tanmay Upadhyay
2011-12-06 11:25 ` Sergei Shtylyov
2011-12-08 4:33 ` [PATCH v2] " Tanmay Upadhyay
2011-12-07 19:57 ` [PATCH] " Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C612856.6090405@einfochips.com \
--to=tanmay.upadhyay@einfochips$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox