public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] pio: add arch specific gpio_is_valid() function
Date: Tue, 24 Aug 2010 10:19:11 +0200	[thread overview]
Message-ID: <4C73807F.4090007@atmel.com> (raw)
In-Reply-To: <30193.50267.qm@web180305.mail.gq1.yahoo.com>

Le 23/08/2010 18:36, David Brownell :
> 
> 
> --- On Mon, 8/23/10, Nicolas Ferre <nicolas.ferre@atmel•com> wrote:
> 
>> From: Nicolas Ferre <nicolas.ferre@atmel•com>
>> Subject: [PATCH] pio: add arch specific gpio_is_valid() function
> 
> What's the rationale?  It's valid or not.  And there's already a
> function whose job it is to report that status ... which is set up
> for arch customization.

How do you customize it? I would like to keep the benefit of gpiolib
implementation.
In arch/arm/mach-at91/include/mach/gpio.h we include the
asm-generic/gpio.h. That is why I protect the generic code with
__HAVE_ARCH_GPIO_IS_VALID.

With this, we can keep the benefit of having an inline function.

>  Which ISTR worked fine for AT91 (among other
> platforms) ...

Well the standard function:
return ((unsigned)number) < ARCH_NR_GPIOS;
is not suitable for AT91 as said in the thread.

Best regards,
-- 
Nicolas Ferre

  reply	other threads:[~2010-08-24  8:19 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090930155557.7dae503b@hskinnemoen-d830>
2009-10-23 16:34 ` [PATCH 0/2 v2]mmc: atmel-mci: introduce MCI2 support on at91 Nicolas Ferre
2009-10-23 16:34 ` [PATCH 1/3 v2] atmel-mci: change use of dma slave interface Nicolas Ferre
2009-10-23 16:34 ` [PATCH 2/3 v2] mmc: atmel-mci: New MCI2 module support in atmel-mci driver Nicolas Ferre
2009-11-02 17:18   ` Nicolas Ferre
2009-11-18 13:33     ` Nicolas Ferre
2009-10-23 16:34 ` [PATCH 3/3 v2] at91/atmel-mci: inclusion of sd/mmc driver in at91sam9g45 chip and board Nicolas Ferre
2009-10-26  8:15   ` Yegor Yefremov
2009-11-02 17:14     ` Nicolas Ferre
2009-10-27 19:43   ` Andrew Victor
2009-10-28  0:35     ` Haavard Skinnemoen
2009-10-28  0:53       ` Thiago A. Corrêa
2009-10-28  1:31         ` Haavard Skinnemoen
2009-10-28 19:53         ` Andrew Victor
2009-10-28 20:50           ` Ben Nizette
2009-11-02 17:11             ` Nicolas Ferre
2009-11-02 22:10               ` Ben Nizette
2009-11-02 22:14               ` Ben Nizette
2009-11-03  2:30               ` Ryan Mallon
2009-11-03  2:55                 ` Ben Nizette
2009-11-07 11:20                   ` Haavard Skinnemoen
2010-08-23 15:01                     ` [PATCH] pio: add arch specific gpio_is_valid() function Nicolas Ferre
2010-08-23 16:36                       ` David Brownell
2010-08-24  8:19                         ` Nicolas Ferre [this message]
2010-09-06 14:21                           ` [PATCH v2] AT91: pio: add " Nicolas Ferre
2010-09-07  1:51                             ` David Brownell
2010-09-03 16:41                       ` [PATCH] pio: add arch specific " Jean-Christophe PLAGNIOL-VILLARD
2010-09-07  2:23                         ` David Brownell
2010-09-07  2:44                           ` Ryan Mallon
2010-09-07  3:54                             ` Eric Miao
2010-09-07  4:07                               ` Ryan Mallon
2010-09-07  4:19                                 ` Eric Miao
2010-09-07  4:26                                   ` Ryan Mallon
2010-09-07 18:10                                     ` David Brownell
2010-09-07 19:13                                       ` avictor.za at gmail.com
2010-09-07 19:30                                         ` Ryan Mallon
2010-09-07 21:22                                           ` Alan Cox
2010-09-07 23:44                                             ` David Brownell
2010-09-08  0:11                                               ` Alan Cox
2010-09-07  6:33                             ` David Brownell
2010-09-07  8:41                               ` Ben Nizette
2010-09-07 17:32                                 ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C73807F.4090007@atmel.com \
    --to=nicolas.ferre@atmel$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox