From: m.szyprowski@samsung•com (Marek Szyprowski)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] ARM: S5PC110: add common FIMC setup code
Date: Mon, 06 Sep 2010 19:21:50 +0900 [thread overview]
Message-ID: <4C84C0BE.3050305@samsung.com> (raw)
In-Reply-To: <AANLkTikakB1Y6N-UT2Hx+PHfdyticHxCFQzs=uc7KWNc@mail.gmail.com>
Hello,
On 2010-09-06 18:17, Jassi Brar wrote:
>> I'm thinking of making the parent clock an argument to the
>> s5pv210_fimc_setup_clks().
> Yes, that's better since the relevant clock is managed by the CMU
What do you mean by the CMU? This function is intended to be called from
board startup code.
>> I really don't like the idea of passing clock name through the platform data
>> and letting driver to mess with clock's parents.
> In case of SPI the clock mux and scalar is present _within_ the SPI
> controller and having to touch SPI regs from outside the driver isn't
> what I prefer.
I know. It is the same case as with SDHCI and UART controllers. I have
an idea how to solve this in a bit more cleaner way. I hope to post a
proposition soon.
>> Machine startup code is the
>> last place where such things should be changed.
> Until I am enlightened, I'd like to think otherwise.
> I think the board designer would already have thought out the clock sourcing
> hierarchy. Setting appropriate parents once at boot-time and having drivers
> not worry about it, should be better.
Definitely, but in our case kernel the default fimc_sclk parent points
to non-existing clock.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2010-09-06 10:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-06 3:50 [PATCH] Platform fixes for s5p-fimc Marek Szyprowski
2010-09-06 3:50 ` [PATCH 1/4] ARM: S5PC110: add fimc clocks Marek Szyprowski
2010-09-09 0:23 ` Kukjin Kim
2010-09-06 3:50 ` [PATCH 2/4] ARM: Samsung: s5p-fimc: fix dma coherent mask Marek Szyprowski
2010-09-09 0:41 ` Kukjin Kim
2010-09-09 1:44 ` Marek Szyprowski
2010-09-09 2:17 ` [PATCH v2] " Marek Szyprowski
2010-09-09 11:20 ` Kukjin Kim
2010-09-14 9:27 ` Marek Szyprowski
2010-09-15 23:49 ` Kukjin Kim
2010-09-06 3:50 ` [PATCH 3/4] ARM: S5PC110: add common FIMC setup code Marek Szyprowski
2010-09-06 4:16 ` Marek Vasut
2010-09-06 4:34 ` Marek Szyprowski
2010-09-06 4:40 ` Marek Vasut
2010-09-06 4:52 ` Jassi Brar
2010-09-06 8:46 ` Marek Szyprowski
2010-09-06 9:17 ` Jassi Brar
2010-09-06 10:21 ` Marek Szyprowski [this message]
2010-09-06 11:28 ` Jassi Brar
2010-09-06 9:10 ` Marek Szyprowski
2010-09-06 3:50 ` [PATCH 4/4] ARM: S5PC110: use common FIMC clock " Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C84C0BE.3050305@samsung.com \
--to=m.szyprowski@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox