public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: ben-linux@fluff•org (Ben Dooks)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] rx1950: add battery device
Date: Wed, 08 Sep 2010 00:06:19 +0100	[thread overview]
Message-ID: <4C86C56B.7090204@fluff.org> (raw)
In-Reply-To: <1283869946-28296-2-git-send-email-anarsoul@gmail.com>

On 07/09/10 15:32, Vasily Khoruzhick wrote:
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail•com>
> ---
>  arch/arm/mach-s3c2440/Kconfig       |    3 +
>  arch/arm/mach-s3c2440/mach-rx1950.c |  160 +++++++++++++++++++++++++++++++++++
>  2 files changed, 163 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c2440/Kconfig b/arch/arm/mach-s3c2440/Kconfig
> index cd8e7de..9b6b026 100644
> --- a/arch/arm/mach-s3c2440/Kconfig
> +++ b/arch/arm/mach-s3c2440/Kconfig
> @@ -198,6 +198,9 @@ config MACH_RX1950
>  	select S3C_DEV_NAND
>  	select S3C2410_IOTIMING if S3C2440_CPUFREQ
>  	select S3C2440_XTAL_16934400
> +	select S3C_ADC
> +	select PDA_POWER
> +	select BATTERY_S3C_ADC

not keen on forcing these on unless they are required for the
system to work.

>  	help
>  	   Say Y here if you're using HP iPAQ rx1950
>  
> diff --git a/arch/arm/mach-s3c2440/mach-rx1950.c b/arch/arm/mach-s3c2440/mach-rx1950.c
> index 142d1f9..1197ab4 100644
> --- a/arch/arm/mach-s3c2440/mach-rx1950.c
> +++ b/arch/arm/mach-s3c2440/mach-rx1950.c
> @@ -25,8 +25,10 @@

> +
> +static const struct s3c_adc_bat_thresh bat_lut_noac[] = {
> +	{4100, 156, 100},
> +	{4050, 156, 95},
> +	{4025, 141, 90},
> +	{3995, 144, 85},
> +	{3957, 162, 80},
> +	{3931, 147, 75},
> +	{3902, 147, 70},
> +	{3863, 153, 65},
> +	{3838, 150, 60},
> +	{3800, 153, 55},
> +	{3765, 153, 50},
> +	{3748, 172, 45},
> +	{3740, 153, 40},
> +	{3714, 175, 35},
> +	{3710, 156, 30},
> +	{3963, 156, 25},
> +	{3672, 178, 20},
> +	{3651, 178, 15},
> +	{3629, 178, 10},
> +	{3612, 162, 5},
> +	{3605, 162, 0},
> +

at least add a space after { and before }
it would be nice to have named initialisers.

  reply	other threads:[~2010-09-07 23:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07 14:32 [PATCH 0/3] rx1950: add rest of devices Vasily Khoruzhick
2010-09-07 14:32 ` [PATCH 1/3] rx1950: add battery device Vasily Khoruzhick
2010-09-07 23:06   ` Ben Dooks [this message]
2010-09-07 23:10     ` Vasily Khoruzhick
2010-09-08  8:58     ` [PATCH v2 " Vasily Khoruzhick
2010-09-25 23:48       ` Ben Dooks
2010-09-26 21:17         ` [PATCH v3 " Vasily Khoruzhick
2010-09-07 14:32 ` [PATCH 2/3] rx1950: add LEDs support Vasily Khoruzhick
2010-09-07 14:32 ` [PATCH 3/3] rx1950: add UDA1380 to i2c devices list Vasily Khoruzhick
2010-09-07 23:07 ` [PATCH 0/3] rx1950: add rest of devices Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C86C56B.7090204@fluff.org \
    --to=ben-linux@fluff$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox