From: lars@metafoo•de (Lars-Peter Clausen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/7] pwm: Align existing pwm drivers with pwm-core driver
Date: Tue, 28 Sep 2010 12:10:53 +0200 [thread overview]
Message-ID: <4CA1BF2D.2070609@metafoo.de> (raw)
In-Reply-To: <F45880696056844FA6A73F415B568C69532DC2FB98@EXDCVYMBSTM006.EQ1STM.local>
Arun MURTHY wrote:
>>> mips-jz4740: pwm: Align with new pwm core driver
>>>
>>> PWM core driver has been added and has been enabled only for ARM
>>> platform. The same can be utilised for mips also.
>>> Please align with the pwm core driver(drivers/pwm-core.c).
>>
>> Is there any reason for artificially limiting it to ARM?
>
> No not at all, right now I have aligned all existing pwm drivers in ARM to make use of the pwm core driver.
> But faced difficulty in aligning the mips-jz4740 pwm driver, without having much knowledge about the device/data sheet.
> Hence I have let it to the maintainer of that driver to align and thereafter this limitation will be removed.
> Have also comments the same as TODO in the driver.
>
Ok, I'll take care of adjusting the jz4740 pwm driver once the pwm-core is in proper
shape.
But I still think it would be better to have a config symbol which would be selected
by SoC code and on which PWM_CORE would depend. Then it would be possible for SoC
implementation to device whether it wants to provide it's own PWM API implementation
or use pwm-core.
>>> diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig
>>> index 5d10106..a88640c 100644
>>> --- a/drivers/pwm/Kconfig
>>> +++ b/drivers/pwm/Kconfig
>>> @@ -4,6 +4,7 @@
>>>
>>> menuconfig PWM_DEVICES
>>> bool "PWM devices"
>>> + depends on ARM
>>> default y
>>> ---help---
>>> Say Y here to get to see options for device drivers from
>> various
>>> diff --git a/drivers/pwm/pwm-core.c b/drivers/pwm/pwm-core.c
>>> index b84027a..3a0d426 100644
>>
>>
>> Why can't these changes be in the initial patch which adds pwm-core?
>>
> Since by default this driver is enabled, and if there is some other pwm driver enabled, both happen to export the same function(pwm_enable/pwm_disable,..) After applying the first patch build may fail.
>
I would understand that if you were just moving code around, but the pwm_device
struct looks completly different now.
> Thanks and Regards,
> Arun R Murthy
> -------------
>
next prev parent reply other threads:[~2010-09-28 10:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-28 7:40 [PATCHv2 0/7] PWM core driver for pwm based led and backlight driver Arun Murthy
2010-09-28 7:40 ` [PATCH 1/7] pwm: Add pwm core driver Arun Murthy
2010-09-28 8:14 ` Vasily Khoruzhick
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FA8F@EXDCVYMBSTM006.EQ1STM.local>
2010-09-28 8:47 ` Vasily Khoruzhick
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FA8F@EXDCVYMBSTM006.EQ1STM.loca l>
2010-09-28 8:50 ` Hemanth V
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FB21@EXDCVYMBSTM006.EQ1STM.local>
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FB21@EXDCVYMBSTM006.EQ1STM.loca l>
2010-09-28 9:34 ` Hemanth V
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FBF9@EXDCVYMBSTM006.EQ1STM.local>
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FBF9@EXDCVYMBSTM006.EQ1STM.loca l>
2010-09-28 10:41 ` Hemanth V
2010-09-28 8:54 ` Lars-Peter Clausen
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FB6B@EXDCVYMBSTM006.EQ1STM.local>
2010-09-28 9:57 ` Lars-Peter Clausen
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FC60@EXDCVYMBSTM006.EQ1STM.local>
2010-09-28 21:04 ` Lars-Peter Clausen
2010-09-29 4:49 ` Arun MURTHY
2010-09-29 12:12 ` Trilok Soni
2010-10-01 3:25 ` Arun MURTHY
2010-10-01 6:47 ` Trilok Soni
2010-10-01 7:25 ` Arun MURTHY
2010-10-01 7:42 ` Jassi Brar
2010-10-01 8:46 ` Arun MURTHY
2010-10-01 10:39 ` Jassi Brar
2010-10-01 18:00 ` Mark Brown
2010-10-04 4:22 ` Arun MURTHY
2010-09-28 17:46 ` Mark Brown
2010-09-28 19:42 ` Ryan Mallon
2010-09-28 7:40 ` [PATCH 2/7] backlight:pwm: add an element 'name' to platform data Arun Murthy
2010-09-28 17:47 ` Mark Brown
2010-09-28 7:40 ` [PATCH 3/7] leds: pwm: add a new " Arun Murthy
2010-09-28 8:01 ` Eric Miao
2010-09-28 8:36 ` Arun MURTHY
2010-09-28 7:40 ` [PATCH 4/7] pwm: Align existing pwm drivers with pwm-core driver Arun Murthy
2010-09-28 8:58 ` Lars-Peter Clausen
[not found] ` <F45880696056844FA6A73F415B568C69532DC2FB98@EXDCVYMBSTM006.EQ1STM.local>
2010-09-28 10:10 ` Lars-Peter Clausen [this message]
2010-09-28 7:40 ` [PATCH 5/7] platform: Update the pwm based led and backlight platform data Arun Murthy
2010-09-28 7:40 ` [PATCH 7/7] pwm: Modify backlight and led Kconfig aligning to pwm core Arun Murthy
[not found] ` <1285659648-21409-7-git-send-email-arun.murthy@stericsson.com>
2010-09-28 8:02 ` [PATCH 6/7] pwm: move existing pwm driver to drivers/pwm Eric Miao
-- strict thread matches above, loose matches on Subject: below --
2010-09-28 10:35 [PATCH 0/7] PWM core driver for pwm based led and backlight driver Arun Murthy
2010-09-28 10:35 ` [PATCH 4/7] pwm: Align existing pwm drivers with pwm-core driver Arun Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA1BF2D.2070609@metafoo.de \
--to=lars@metafoo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox