Subject: [PATCH 52/74] ST SPEAr13xx: Adding CPU hotplug support added for SMP platforms

From: [email-masked] (Shiraz Hashim)
Date: Thu, 30 Sep 2010 15:07:08 +0530

Hello Sundar,

Sorry for replying so late :).

On 9/3/2010 11:30 AM, Sundar wrote:
> Hi,
> 
> On Mon, Aug 30, 2010 at 4:09 PM, Viresh KUMAR <[email-masked]> wrote:
>> From: Deepak Sikri <[email-masked]>
>>
>> Signed-off-by: Deepak Sikri <[email-masked]>
>> Signed-off-by: shiraz hashim <[email-masked]>
>> Signed-off-by: Viresh Kumar <[email-masked]>
>> ---
> 
>> +       flush_cache_all();
>> +       asm volatile(
>> +       "       mcr     p15, 0, %1, c7, c5, 0\n"
>> +       "       mcr     p15, 0, %1, c7, c10, 4\n"
> 
> Isnt this a Cortex-A9 platform? If yes, then this is not implemented
> on the Cortex-A9 if I am right.
> You should use a dsb() here.

yes, I would place dsb here.

>> +               /*
>> +                * here's the WFI
>> +                */
>> +               asm(".word      0xe320f003\n"
>> +                   :
> 
> Also, why not a simple asm volatile("wfi" : : : "memory"); instead of
> hard coded values.

Would add a wfi() macro in asm/system.h including sev() as suggested by
Russell. This statement would be replaced by a simple wfi().

regards
Shiraz