From: richard.rojfors@pelagicore•com (Richard Röjfors)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data
Date: Thu, 30 Sep 2010 11:54:53 +0200 [thread overview]
Message-ID: <4CA45E6D.4070308@pelagicore.com> (raw)
In-Reply-To: <20100930081605.GA2655@pengutronix.de>
On 09/30/2010 10:16 AM, Wolfram Sang wrote:
> Hi Richard,
>
> On Wed, Sep 29, 2010 at 11:24:25PM +0200, Richard R?jfors wrote:
>> On 09/29/2010 10:07 PM, Wolfram Sang wrote:
>>> We need to carry some information per host, e.g. the clock. Add a
>>> structure for it and initialize it in the generic part. Also do not use
>>> the parent of the platform_device (if it is available), this breaks the
>>> clock-matching on ARM.
>>
>> The reason it's there is for instance a case when the shdci device is exposed
>> from a MFD device which sits on top of PCI. Then the parent (PCI device)
>> is the device that is DMA capable. This patch will break such usage.
>
> I feared that there is a reason. The problem I see is now, that the parent gets
> always set (from drivers/base/platform.c):
Then we obviously need to pass more information in the platform_data to be able
to chose which device to be used.
>
> So, sdhci-plftm cannot access the platform_data connected to the original
> platform_device via host->mmc->parent.
You're right it wouldn't. But isn't it a bit risky even if you could access it,
in the long the platform_data coild point to something that is in the __devinit section
or similar?
What about extend the struct you defined with the pieces needed, and access it via
sdhci_priv?
>> What is the purpose of this patch? You allocate space for an extra struct,
>> which you have a pointer pointing to, but you never use the pointer?
>
> We want to extend sdhci-pltfm to support the various sdhci-cores on (for now
> mainly) ARM platforms. A number of those cores need board specific information
> to be used in a custom init()-call, which shall be passed via platform_data.
> The pointer will be used in the platform specific extensions.
Sounds good.
Regards,
Richard
>
>>>
>>> Signed-off-by: Wolfram Sang<w.sang@pengutronix•de>
>>> Cc: Richard R?jfors<richard.rojfors.ext@mocean-labs•com>
>>> ---
>>>
>>> Changes since last version:
>>>
>>> * added types.h
>>
>> I saw no types.h?
>
> In the second chunk, the include file.
>
> Thanks,
>
> Wolfram
>
>>
>>> * removed usage of pdev->dev.parent to ensure clk-matching
>>> Please speak up if this has a use case I failed to see!
>>>
>>> drivers/mmc/host/sdhci-pltfm.c | 8 ++++----
>>> drivers/mmc/host/sdhci-pltfm.h | 7 +++++++
>>> 2 files changed, 11 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
>>> index e045e3c..095ca9d 100644
>>> --- a/drivers/mmc/host/sdhci-pltfm.c
>>> +++ b/drivers/mmc/host/sdhci-pltfm.c
>>> @@ -55,6 +55,7 @@ static int __devinit sdhci_pltfm_probe(struct platform_device *pdev)
>>> struct sdhci_pltfm_data *pdata = pdev->dev.platform_data;
>>> const struct platform_device_id *platid = platform_get_device_id(pdev);
>>> struct sdhci_host *host;
>>> + struct sdhci_pltfm_host *pltfm_host;
>>> struct resource *iomem;
>>> int ret;
>>>
>>> @@ -71,16 +72,15 @@ static int __devinit sdhci_pltfm_probe(struct platform_device *pdev)
>>> dev_err(&pdev->dev, "Invalid iomem size. You may "
>>> "experience problems.\n");
>>>
>>> - if (pdev->dev.parent)
>>> - host = sdhci_alloc_host(pdev->dev.parent, 0);
>>> - else
>>> - host = sdhci_alloc_host(&pdev->dev, 0);
>>> + host = sdhci_alloc_host(&pdev->dev, sizeof(*pltfm_host));
>>>
>>> if (IS_ERR(host)) {
>>> ret = PTR_ERR(host);
>>> goto err;
>>> }
>>>
>>> + pltfm_host = sdhci_priv(host);
>>> +
>>> host->hw_name = "platform";
>>> if (pdata&& pdata->ops)
>>> host->ops = pdata->ops;
>>> diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
>>> index 900f329..93a0319 100644
>>> --- a/drivers/mmc/host/sdhci-pltfm.h
>>> +++ b/drivers/mmc/host/sdhci-pltfm.h
>>> @@ -11,8 +11,15 @@
>>> #ifndef _DRIVERS_MMC_SDHCI_PLTFM_H
>>> #define _DRIVERS_MMC_SDHCI_PLTFM_H
>>>
>>> +#include<linux/clk.h>
>>> +#include<linux/types.h>
>>> #include<linux/sdhci-pltfm.h>
>>>
>>> +struct sdhci_pltfm_host {
>>> + struct clk *clk;
>>> + u32 scratchpad; /* to handle quirks across io-accessor calls */
>>> +};
>>> +
>>> extern struct sdhci_pltfm_data sdhci_cns3xxx_pdata;
>>>
>>> #endif /* _DRIVERS_MMC_SDHCI_PLTFM_H */
>
next prev parent reply other threads:[~2010-09-30 9:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 20:07 [PATCH V3 0/6] SD/MMC-driver for MX35/51 (and improvements to SDHCI) Wolfram Sang
2010-09-29 20:07 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-09-29 21:24 ` Richard Röjfors
2010-09-30 8:16 ` Wolfram Sang
2010-09-30 9:54 ` Richard Röjfors [this message]
2010-09-30 10:19 ` Wolfram Sang
2010-09-30 11:09 ` Anton Vorontsov
2010-09-29 20:08 ` [PATCH 2/6] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-09-29 20:08 ` [PATCH 3/6] mmc: sdhci: introduce private get_ro Wolfram Sang
2010-09-29 20:08 ` [PATCH 4/6] mmc: sdhci_pltfm: pass more data on custom init-call Wolfram Sang
2010-09-30 8:31 ` Lothar Waßmann
2010-09-30 9:42 ` Anton Vorontsov
2010-10-11 11:07 ` Wolfram Sang
2010-09-29 20:08 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-09-29 20:08 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-09-29 20:14 ` Chris Ball
2010-10-02 15:15 ` [PATCH 1/4] mach-cpuimx35: remove unecessary tsc2007 functions + style cleanup Eric Bénard
2010-10-02 15:15 ` [PATCH 2/4] eukrea_mbimxsd for cpuimx35: add CAN & SDCard support Eric Bénard
2010-10-08 13:43 ` imx-for-2.6.37 broken [Was: [PATCH 2/4] eukrea_mbimxsd for cpuimx35: add CAN & SDCard support] Uwe Kleine-König
2010-10-02 15:15 ` [PATCH 3/4] i.mx25: add esdhc support Eric Bénard
2010-10-02 15:15 ` [PATCH 4/4] eukrea_mbimxsd for cpuimx25: add CAN & SDCard support Eric Bénard
2010-10-02 15:17 ` [PATCH V3 0/6] SD/MMC-driver for MX35/51 (and improvements to SDHCI) Eric Bénard
-- strict thread matches above, loose matches on Subject: below --
2010-10-11 14:21 [PATCH 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-11 14:21 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-10-15 10:20 [PATCH V5 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-15 10:20 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA45E6D.4070308@pelagicore.com \
--to=richard.rojfors@pelagicore$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox