From: b-cousson@ti•com (Cousson, Benoit)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init
Date: Fri, 1 Oct 2010 19:12:38 +0200 [thread overview]
Message-ID: <4CA61686.3050801@ti.com> (raw)
In-Reply-To: <8762xmdldv.fsf@deeprootsystems.com>
On 10/1/2010 4:43 PM, Kevin Hilman wrote:
> "Varadarajan, Charulatha"<charu@ti•com> writes:
>
>> Tony, Benoit, Kevin,
>>
>>>>>>>>
>>>>>>>> I think that disabling it should be done only if the
>>>> CONFIG_OMAP_WDT
>>>>>>>> is not set.
>>>>>>>
>>>>>>> How about disabling is done always unless CONFIG_WATCHDOG_NOWAYOUT
>>>>>>> is set?
>>>>>>
>>>>>> As given in the patch description, this patch does a disable of
>>>> watchdog
>>>>>> timer, during init, to avoid the system rebooting that happens due to
>>>>>> enabling of watchdog timer after a reset of the module (during hwmod
>>>> init).
>>>>>>
>>>>>> According to the default WDT registers values, the system reboot
>>> would
>>>>>> happen in ~10s if watchdog is enabled with default values. Hence,
>>> after
>>>>>> a WDT module reset during init, the watchdog has to be disabled
>>> within
>>>> 10s
>>>>>> otherwise the system will keep rebooting.
>>>>>>
>>>>>> Hence irrespective of CONFIG_WATCHDOG_NOWAYOUT/ CONFIG_OMAP_WDT,
>>>>>> the watchdog timer needs to be disabled after a WDT reset has
>>> happened.
>>>>>>
>>>>> One more option is to avoid the software reset using the
>>> CONFIG_OMAP_WDT
>>>>> flag. Something like below.
>>>>
>>>> This was already proposed by Charu, and rejected.
>>>>
>>>> Doing this means we have a dependency on particular bootloader init, and
>>>> we'd like to get rid of *all* assumptions about what the bootloader does
>>>> (or does not do.)
>>>>
>>> you mean is not depeding on bootloader to disable WDT. Make sense.
>>>
>>
>> Let me know your opinion on how to handle this issue.
>
> IMO, we should do what your original patch did: always disable the WDT,
> just like most/all bootloaders do.
>
> If we want to make changes later to support product needs (like no
> disable on boot, etc.) that is a separate issue and should be done in a
> separate patch.
Let's do that, since we still don't have a clue how it is supposed to be
used by a product. If someone find out the answer, he'll fix that.
Benoit
next prev parent reply other threads:[~2010-10-01 17:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 8:11 [PATCH] OMAP2PLUS: WDT: Fix: Disable WDT after reset during init Varadarajan, Charulatha
2010-09-30 9:07 ` Cousson, Benoit
2010-09-30 13:55 ` Kevin Hilman
2010-09-30 14:12 ` Cousson, Benoit
2010-09-30 14:51 ` Kevin Hilman
2010-09-30 15:07 ` Tony Lindgren
2010-09-30 15:55 ` Varadarajan, Charulatha
2010-09-30 16:32 ` Varadarajan, Charulatha
2010-09-30 16:43 ` Paul Walmsley
2010-09-30 16:51 ` Tony Lindgren
2010-09-30 16:46 ` Cousson, Benoit
2010-09-30 16:57 ` Cousson, Benoit
2010-09-30 17:06 ` Varadarajan, Charulatha
2010-09-30 17:05 ` Shilimkar, Santosh
2010-09-30 17:11 ` Kevin Hilman
2010-10-01 7:26 ` Shilimkar, Santosh
2010-10-01 13:33 ` Varadarajan, Charulatha
2010-10-01 14:43 ` Kevin Hilman
2010-10-01 17:12 ` Cousson, Benoit [this message]
2010-09-30 13:57 ` Kevin Hilman
2010-09-30 16:36 ` Varadarajan, Charulatha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA61686.3050801@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox