From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ulpi: add i.MX25 & 35 internal PHY ID
Date: Mon, 04 Oct 2010 17:15:35 +0200 [thread overview]
Message-ID: <4CA9EF97.5040908@compulab.co.il> (raw)
In-Reply-To: <4CA9EAA0.2060608@ru.mvista.com>
On 10/04/10 16:54, Sergei Shtylyov wrote:
> Hello.
>
> Eric B?nard wrote:
>
>> without this patch, the initialization of the OTG port in host mode
>> fails with :
>> ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
>> mxc-ehci mxc-ehci.0: initializing i.MX USB Controller
>> ULPI transceiver vendor/product ID 0x0000/0x0000
>> ULPI ID does not match any known transceiver.
>> mxc-ehci mxc-ehci.0: unable to init transceiver, probably missing
>
>> Signed-off-by: Eric B?nard <eric@eukrea•com>
>> ---
>> drivers/usb/otg/ulpi.c | 5 ++++-
>> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> You should have CC'ed linux-usb at vger.kernel.org.
>
>> diff --git a/drivers/usb/otg/ulpi.c b/drivers/usb/otg/ulpi.c
>> index ccc8195..e802e44 100644
>> --- a/drivers/usb/otg/ulpi.c
>> +++ b/drivers/usb/otg/ulpi.c
>> @@ -34,7 +34,10 @@
>> /* ULPI hardcoded IDs, used for probing */
>> static unsigned int ulpi_ids[] = {
>> ULPI_ID(0x04cc, 0x1504), /* NXP ISP1504 */
>> - ULPI_ID(0x0424, 0x0006), /* SMSC USB3319 */
>> + ULPI_ID(0x0424, 0x0006), /* SMSC USB3319 */
>> +#if (defined(CONFIG_ARCH_MX25) || defined(CONFIG_ARCH_MX35))
>> + ULPI_ID(0x0000, 0x0000), /* i.MX25 & i.MX35 internal PHY */
>> +#endif
>
> I don't know why this table is at all used in the first place. IMO, checking for the vendor/device ID serves no purpose...
Well, it was there in first place, when Daniel merged this.
May be it was taken from Sascha.
I think its purpose to check if there is a ulpi transceiver out there,
although, ulpi defines a special scratch register for testing purposes.
>
> WBR, Sergei
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Regards,
Igor.
next prev parent reply other threads:[~2010-10-04 15:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-04 12:23 [PATCH] ulpi: add i.MX25 & 35 internal PHY ID Eric Bénard
2010-10-04 14:54 ` Sergei Shtylyov
2010-10-04 15:15 ` Igor Grinberg [this message]
2010-10-05 5:42 ` Daniel Mack
2010-10-05 12:59 ` Igor Grinberg
2010-10-05 15:12 ` Eric Bénard
2010-10-05 15:42 ` Igor Grinberg
2010-10-05 15:50 ` Eric Bénard
2010-10-05 16:51 ` [PATCH] cpuimx25 & cpuimx35: fix OTG port registration in host mode Eric Bénard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CA9EF97.5040908@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox