From: ryan@bluewatersys•com (Ryan Mallon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ASoC: Add CS4271 codec support
Date: Thu, 07 Oct 2010 13:53:54 +1300 [thread overview]
Message-ID: <4CAD1A22.7090306@bluewatersys.com> (raw)
In-Reply-To: <20101007004940.GC30751@opensource.wolfsonmicro.com>
On 10/07/2010 01:49 PM, Mark Brown wrote:
> On Thu, Oct 07, 2010 at 01:39:01PM +1300, Ryan Mallon wrote:
>> From: Alexander Sverdlin <subaparts@yandex•ru>
>>
>> Added support for Cirrus CS4271 codec to ALSA SoC subsystem.
>>
>> Applies on: 2.6.36-rc6
>
Ugh, I managed to miss Alexander from the CC list :-/. Alexander, can
you please update the patch as detailed below.
~Ryan
> Unfortunately there have been major changes in the ASoC APIs in -next
> for Liam's multi-component work so you'll need to update this before it
> can be applied. You should always submit code against -next (except for
> bug fixes to be sent to Linus).
>
> See
>
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound-2.6.git
>
> for current code.
>
> I gave the driver a quick review and it looks really good - it just
> needs to be updated for current APIs.
>
>> +static const struct snd_kcontrol_new cs4271_snd_controls[] = {
>> + SOC_DOUBLE_R("Master Playback Volume", CS4271_VOLA, CS4271_VOLB, 0, 0x7F, 1),
>
> TLV information would be nice but isn't essential.
>
>> + SOC_SINGLE("Digital Loopback Switch", CS4271_MODE2, 4, 1, 0),
>
> This should probably be done as part of DAPM. Again probably not
> essential.
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2010-10-07 0:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-07 0:39 [PATCH 1/2] ASoC: Add CS4271 codec support Ryan Mallon
2010-10-07 0:49 ` Mark Brown
2010-10-07 0:53 ` Ryan Mallon [this message]
2010-10-07 0:50 ` Mark Brown
2010-10-07 0:50 ` [PATCH 2/2] ASoC: EDB93xx machine sound driver Ryan Mallon
2010-10-07 3:12 ` Mark Brown
2010-10-07 21:46 ` [PATCH 1/2] ASoC: Add CS4271 codec support Timur Tabi
2010-10-07 21:59 ` Ryan Mallon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CAD1A22.7090306@bluewatersys.com \
--to=ryan@bluewatersys$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox