From: sourav.poddar@ti•com (Sourav Poddar)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4] ARM: Fix sparse warnings due to variables conflicts.
Date: Thu, 14 Oct 2010 10:06:13 +0530 [thread overview]
Message-ID: <4CB688BD.5070406@ti.com> (raw)
In-Reply-To: <20101008232237.GC10975@n2100.arm.linux.org.uk>
On Saturday 09 October 2010 04:52 AM, Russell King - ARM Linux wrote:
> On Fri, Oct 08, 2010 at 06:32:29AM -0500, Nishanth Menon wrote:
>
>> Poddar, Sourav had written, on 10/08/2010 12:53 AM, the following:
>>
>>> Fix the sparse warnings generated due to conflicts in variables used in readl/writel.
>>>
>>>
>>> drivers/net/smc91x.c:312:8: warning: symbol '__v' shadows an earlier one
>>> drivers/net/smc91x.c:312:8: originally declared here
>>>
>>> With this change, about 200 sparse warnings are fixed.
>>>
>> The commit message could be a little more detailed.
>> see http://marc.info/?l=linux-omap&m=128648102511076&w=2
>>
>> also should $subject say ARM: io: fix namespace conflict
>> to better reflect the fix? sparse warnings are just an indication IMHO
>>
> afaics, this patch will cause checkpatch to issue warnings due to lines
> over 80 characters.
>
> I can't check that because I don't have the original patch via the
> linux-arm-kernel mailing list.
>
Hi,
I have posted a new patch with the checkpatch issues fixed.
Link to this patch is:
http://marc.info/?l=linux-arm-kernel&m=128697013901237&w=2
Regards,
Sourav
prev parent reply other threads:[~2010-10-14 4:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1286517186-29934-1-git-send-email-sourav.poddar@ti.com>
2010-10-08 11:32 ` [PATCH v4] ARM: Fix sparse warnings due to variables conflicts Nishanth Menon
2010-10-08 17:36 ` Tony Lindgren
2010-10-11 3:44 ` G, Manjunath Kondaiah
2010-10-08 23:22 ` Russell King - ARM Linux
2010-10-11 5:45 ` Varadarajan, Charulatha
2010-10-14 4:36 ` Sourav Poddar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CB688BD.5070406@ti.com \
--to=sourav.poddar@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox