From: ben-linux@fluff•org (Ben Dooks)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API
Date: Thu, 21 Oct 2010 23:17:45 +0100 [thread overview]
Message-ID: <4CC0BC09.5090803@fluff.org> (raw)
In-Reply-To: <1287648286-7202-1-git-send-email-kgene.kim@samsung.com>
On 21/10/10 09:04, Kukjin Kim wrote:
> From: Daein Moon <moon9124@samsung•com>
>
> This patch adds the s3c_gpio_getpull() API that has been missed in the
> plat-samsung/gpio-config.c and actullay there is its extern declaration
> in plat/gpio-cfg.h.
>
> Signed-off-by: Daein Moon <moon9124@samsung•com>
> Cc: Ben Dooks <ben-linux@fluff•org>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung•com>
> ---
> NOTE:
> - already issued about this
>
> arch/arm/plat-samsung/gpio-config.c | 19 +++++++++++++++++++
> .../plat-samsung/include/plat/gpio-cfg-helpers.h | 6 ++++++
> 2 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/gpio-config.c b/arch/arm/plat-samsung/gpio-config.c
> index 8a37211..b732b77 100644
> --- a/arch/arm/plat-samsung/gpio-config.c
> +++ b/arch/arm/plat-samsung/gpio-config.c
> @@ -111,6 +111,25 @@ int s3c_gpio_setpull(unsigned int pin, s3c_gpio_pull_t pull)
> }
> EXPORT_SYMBOL(s3c_gpio_setpull);
>
> +s3c_gpio_pull_t s3c_gpio_getpull(unsigned int pin)
> +{
> + struct s3c_gpio_chip *chip = s3c_gpiolib_getchip(pin);
> + unsigned long flags;
> + int offset;
> + u32 pup = 0;
would the result of s3c_gpio_do_getpull() should be a s3c_gpio_pull_t?
> + if (chip) {
> + offset = pin - chip->chip.base;
> +
> + s3c_gpio_lock(chip, flags);
> + pup = s3c_gpio_do_getpull(chip, offset);
> + s3c_gpio_unlock(chip, flags);
> + }
> +
> + return (__force s3c_gpio_pull_t)pup;
> +}
> +EXPORT_SYMBOL(s3c_gpio_getpull);
next prev parent reply other threads:[~2010-10-21 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 8:04 [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API Kukjin Kim
2010-10-21 17:47 ` Sergei Shtylyov
2010-10-22 8:05 ` Kukjin Kim
2010-10-21 22:17 ` Ben Dooks [this message]
2010-10-22 5:22 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC0BC09.5090803@fluff.org \
--to=ben-linux@fluff$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox