Subject: [sodaville] [PATCH 1/7] i2c/pxa2xx: Don't touch ISAR if not in slave mode

From: [email-masked] (Sebastian Andrzej Siewior)
Date: Fri, 26 Nov 2010 19:28:32 +0100

Ben Dooks wrote:
>> +#ifdef CONFIG_I2C_PXA_SLAVE
>>  	writel(i2c->slave_addr, _ISAR(i2c));
>> +#endif
> 
> I was thinking about whether to add a flag to this to say whether the
> slave_addr field is valid, but to keep full compatiblity with the existing
> pxa users, we'd have to go and change every board using it.

i2c->slave_addr is 1 if slave mode is not enabled. Why should this value
be used in master mode?

Sebastian