From: phorton@bitbox•co.uk (Peter Horton)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] mx51: add support for FIQ on TZIC
Date: Mon, 06 Dec 2010 09:39:37 +0000 [thread overview]
Message-ID: <4CFCAF59.7090105@bitbox.co.uk> (raw)
In-Reply-To: <20101206074359.GR6017@pengutronix.de>
On 06/12/2010 07:43, Sascha Hauer wrote:
> On Fri, Dec 03, 2010 at 04:16:26PM +0000, Peter Horton wrote:
>> Add support for FIQ on mx51 TZIC
>>
>> TZIC changes tested with FIQ audio on an mx51 board
>>
>> AVIC changes build with mx3_defconfig, not tested
>>
[snip]
>> }
>> diff --git a/arch/arm/plat-mxc/include/mach/entry-macro.S b/arch/arm/plat-mxc/include/mach/entry-macro.S
>> index aeb0869..c7dd4a9 100644
>> --- a/arch/arm/plat-mxc/include/mach/entry-macro.S
>> +++ b/arch/arm/plat-mxc/include/mach/entry-macro.S
>> @@ -54,8 +54,18 @@
>> #elif defined CONFIG_MXC_TZIC
>> @ Load offset& priority of the highest priority
>> @ interrupt pending.
>> + @ 0x080 is INTSEC0 register
>> @ 0xD80 is HIPND0 register
>> mov \irqnr, #0
>> +#ifdef CONFIG_FIQ
>> +1000:
>> + add \irqstat, \base, \irqnr, lsr #3
>> + ldr \tmp, [\irqstat, #0xd80]
>> + ldr \irqstat, [\irqstat, #0x080]
>> + ands \tmp, \tmp, \irqstat
>> + bne 1001f
>> + add \irqnr, \irqnr, #32
>> +#else
>> mov \irqstat, #0x0D80
>> 1000:
>> ldr \tmp, [\irqstat, \base]
>> @@ -63,6 +73,7 @@
>> bne 1001f
>> addeq \irqnr, \irqnr, #32
>> addeq \irqstat, \irqstat, #4
>> +#endif
>
> Can't we skip the #ifdef? The CONFIG_FIQ path should also work without FIQs
> enabled, right?
>
Yes.
P.
prev parent reply other threads:[~2010-12-06 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 16:16 [PATCH] mx51: add support for FIQ on TZIC Peter Horton
2010-12-06 7:43 ` Sascha Hauer
2010-12-06 9:39 ` Peter Horton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFCAF59.7090105@bitbox.co.uk \
--to=phorton@bitbox$(echo .)co.uk \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox