From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v9 6/6] davinci: USB1.1 support for Omapl138-Hawkboard
Date: Mon, 06 Dec 2010 14:43:18 +0300 [thread overview]
Message-ID: <4CFCCC56.3010700@mvista.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB5930247C46537@dbde02.ent.ti.com>
Hello.
On 06-12-2010 14:12, Nori, Sekhar wrote:
>> arch/arm/mach-davinci/board-omapl138-hawk.c | 38 ++++++++++++++++++++------
>> 1 files changed, 29 insertions(+), 9 deletions(-)
>> diff --git a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> b/arch/arm/mach-davinci/board-omapl138-hawk.c
>> index da51136..8fc78f2 100644
>> --- a/arch/arm/mach-davinci/board-omapl138-hawk.c
>> +++ b/arch/arm/mach-davinci/board-omapl138-hawk.c
[...]
>> @@ -165,13 +165,23 @@ static __init void omapl138_hawk_mmc_init(void)
>> if (ret< 0) {
>> pr_warning("%s: can not open GPIO %d\n",
>> __func__, DA850_HAWK_MMCSD_WP_PIN);
>> - return;
>> + goto exp_setup_wp_fail;
>> }
>>
>> ret = da8xx_register_mmcsd0(&da850_mmc_config);
>> - if (ret)
>> + if (ret) {
>> pr_warning("%s: MMC/SD0 registration failed: %d\n",
>> __func__, ret);
>> + goto exp_setup_mmcsd_fail;
>> + }
>> + return;
> This return has extra indentation.
>> +
>> +exp_setup_mmcsd_fail:
>> + gpio_free(DA850_HAWK_MMCSD_WP_PIN);
>> +exp_setup_wp_fail:
>> + gpio_free(DA850_HAWK_MMCSD_CD_PIN);
>> +exp_setup_cd_fail:
>> + return;
> This one too.
Moreover, it's not needed at all.
> Other than that, it all looks good to me.
Except those 'exp_setup_'prefixes which I'm not sure where are coming from...
> Thanks,
> Sekhar
WBR, Sergei
next prev parent reply other threads:[~2010-12-06 11:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1291231949-23835-1-git-send-email-vm.rod25@gmail.com>
2010-12-01 19:32 ` [PATCH v9 1/6] davinci: EMAC support for Omapl138-Hawkboard vm.rod25 at gmail.com
2010-12-01 19:32 ` [PATCH v9 2/6] davinci: EDMA " vm.rod25 at gmail.com
2010-12-01 19:32 ` [PATCH v9 3/6] davinci: MMC/SD and USB-OHCI configuration " vm.rod25 at gmail.com
2010-12-01 19:32 ` [PATCH v9 4/6] davinci: MMC/SD support " vm.rod25 at gmail.com
2010-12-01 19:32 ` [PATCH v9 5/6] davinci: USB clocks " vm.rod25 at gmail.com
2010-12-01 19:32 ` [PATCH v9 6/6] davinci: USB1.1 support " vm.rod25 at gmail.com
2010-12-02 6:49 ` Nori, Sekhar
2010-12-03 0:44 ` Victor Rodriguez
2010-12-03 11:51 ` Nori, Sekhar
2010-12-03 17:10 ` Victor Rodriguez
2010-12-06 11:12 ` Nori, Sekhar
2010-12-06 11:43 ` Sergei Shtylyov [this message]
2010-12-06 15:47 ` Victor Rodriguez
2010-12-06 15:53 ` Ben Gardiner
2010-12-06 15:56 ` Victor Rodriguez
2010-12-06 17:48 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFCCC56.3010700@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox