From: b-cousson@ti•com (Cousson, Benoit)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC/PATCH 11/14] dt: omap3: add soc file for handling i2c controllers
Date: Wed, 10 Aug 2011 14:36:50 +0200 [thread overview]
Message-ID: <4E427B62.1000907@ti.com> (raw)
In-Reply-To: <1312897232-4792-12-git-send-email-manjugk@ti.com>
On 8/9/2011 4:10 PM, G, Manjunath Kondaiah wrote:
>
> Add omap3 soc file for handling omap3 soc i2c controllers existing
> on l4-core bus.
>
> Signed-off-by: G, Manjunath Kondaiah<manjugk@ti•com>
> ---
> arch/arm/boot/dts/omap3-soc.dtsi | 62 ++++++++++++++++++++++++++++++++++++++
> 1 files changed, 62 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/boot/dts/omap3-soc.dtsi
>
> diff --git a/arch/arm/boot/dts/omap3-soc.dtsi b/arch/arm/boot/dts/omap3-soc.dtsi
> new file mode 100644
> index 0000000..85de92f
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-soc.dtsi
> @@ -0,0 +1,62 @@
> +/*
> + * Device Tree Source for OMAP3 SoC
> + *
> + * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
> + *
> + * This file is licensed under the terms of the GNU General Public License
> + * version 2. This program is licensed "as is" without any warranty of any
> + * kind, whether express or implied.
> + */
> +
> +/dts-v1/;
> +/include/ "skeleton.dtsi"
> +
> +/ {
> + #address-cells =<1>;
> + #size-cells =<1>;
> + model = "ti,omap3";
> +
> + aliases {
> + i2c1 =&i2c1;
> + i2c2 =&i2c2;
> + i2c3 =&i2c3;
> + };
> +
> + l4-core {
That comment is probably subject to discussion, but even if this
interconnect is there physically, I'm not sure of the added value to add it.
It will add an extra level of indentation and that all. Moreover, it
will mess up the physical address that are expressed using absolute
value in the TRM with a less readable offset value.
In fact, most DTS files in the ARM directory are using a purely flat
representation of the interconnect.
> + compatible = "ti,omap3-l4-core";
Assuming we will keep that, you should probably add a more generic
compatible name after that one. Like "ti,s3220" or even "sonics,s3220",
assuming that this IP is generic enough for other SoC.
> + #address-cells =<1>;
> + #size-cells =<1>;
> + ranges =<0 0x48000000 0x1000000>;
> +
> + i2c1: i2c at 70000 {
> + #address-cells =<1>;
> + #size-cells =<0>;
> + compatible = "ti,omap3-i2c";
The I2C IP and thus the driver is generic across OMAP generations and is
even potentially used by other non-OMAP TI chips like DSP or Davinci. So
having an extra compatible entry with "ti,i2c" or "ti, omap-i2c" seems
mandatory.
Regards,
Benoit
next prev parent reply other threads:[~2011-08-10 12:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1312897232-4792-1-git-send-email-manjugk@ti.com>
2011-08-10 5:26 ` [RFC/PATCH 00/14] dt: omap hwmod-dt binding and omap3 i2c1 dt support Rajendra Nayak
2011-08-10 5:30 ` G, Manjunath Kondaiah
2011-08-10 5:39 ` Rajendra Nayak
2011-08-10 6:28 ` G, Manjunath Kondaiah
[not found] ` <1312897232-4792-5-git-send-email-manjugk@ti.com>
2011-08-10 7:07 ` [RFC/PATCH 04/14] OMAP: McBSP: use existing macros for converting between devices Jarkko Nikula
2011-08-10 10:15 ` Cousson, Benoit
2011-08-10 16:05 ` G, Manjunath Kondaiah
[not found] ` <1312897232-4792-10-git-send-email-manjugk@ti.com>
2011-08-10 11:51 ` [RFC/PATCH 09/14] dt: omap: prepare hwmod to support dt Cousson, Benoit
2011-08-10 16:28 ` G, Manjunath Kondaiah
2011-08-10 17:11 ` Cousson, Benoit
2011-08-10 18:03 ` G, Manjunath Kondaiah
2011-08-10 18:06 ` Cousson, Benoit
2011-08-16 15:02 ` G, Manjunath Kondaiah
[not found] ` <1312897232-4792-11-git-send-email-manjugk@ti.com>
2011-08-10 11:57 ` [RFC/PATCH 10/14] dt: Add pd_size to AUXDATA structure Cousson, Benoit
2011-08-10 13:16 ` Grant Likely
2011-08-10 16:02 ` G, Manjunath Kondaiah
[not found] ` <1312897232-4792-12-git-send-email-manjugk@ti.com>
2011-08-10 12:36 ` Cousson, Benoit [this message]
2011-08-10 16:57 ` [RFC/PATCH 11/14] dt: omap3: add soc file for handling i2c controllers G, Manjunath Kondaiah
2011-08-10 17:45 ` Cousson, Benoit
2011-08-16 6:32 ` G, Manjunath Kondaiah
[not found] ` <1312897232-4792-13-git-send-email-manjugk@ti.com>
2011-08-10 12:42 ` [RFC/PATCH 12/14] dt: omap3: beagle board: set clock freq for i2c devices Cousson, Benoit
2011-08-10 16:45 ` G, Manjunath Kondaiah
[not found] ` <1312897232-4792-15-git-send-email-manjugk@ti.com>
2011-08-10 12:57 ` [RFC/PATCH 14/14] dt: omap3: enable dt support for i2c1 controller Cousson, Benoit
2011-08-16 18:44 ` G, Manjunath Kondaiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E427B62.1000907@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox