From: rnayak@ti•com (Rajendra Nayak)
To: linux-arm-kernel@lists•infradead.org
Subject: [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver
Date: Thu, 11 Aug 2011 19:55:22 +0530 [thread overview]
Message-ID: <4E43E652.5020303@ti.com> (raw)
In-Reply-To: <20110811141248.GK28500@legolas.emea.dhcp.ti.com>
On 8/11/2011 7:42 PM, Felipe Balbi wrote:
> Hi,
>
> On Thu, Aug 11, 2011 at 06:30:04PM +0530, J, KEERTHY wrote:
>>>>>> > >> >> diff --git a/drivers/hwmon/omap_temp_sensor.c b/drivers/hwmon/omap_temp_sensor.c
>>>>>> > >> >> new file mode 100644
>>>>>> > >> >> index 0000000..15e2559
>>>>>> > >> >> --- /dev/null
>>>>>> > >> >> +++ b/drivers/hwmon/omap_temp_sensor.c
>>>>>> > >> >> @@ -0,0 +1,950 @@
>>>>>> > >> >> +/*
>>>>>> > >> >> + * OMAP4 Temperature sensor driver file
>>>>>> > >> >> + *
>>>>>> > >> >> + * Copyright (C) 2011 Texas Instruments Incorporated -http://www.ti.com/
>>>>>> > >> >> + * Author: J Keerthy<j-keerthy@ti•com>
>>>>>> > >> >> + * Author: Moiz Sonasath<m-sonasath@ti•com>
>>>>>> > >> >> + *
>>>>>> > >> >> + * This program is free software; you can redistribute it and/or
>>>>>> > >> >> + * modify it under the terms of the GNU General Public License
>>>>>> > >> >> + * version 2 as published by the Free Software Foundation.
>>>>>> > >> >> + *
>>>>>> > >> >> + * This program is distributed in the hope that it will be useful, but
>>>>>> > >> >> + * WITHOUT ANY WARRANTY; without even the implied warranty of
>>>>>> > >> >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
>>>>>> > >> >> + * General Public License for more details.
>>>>>> > >> >> + *
>>>>>> > >> >> + * You should have received a copy of the GNU General Public License
>>>>>> > >> >> + * along with this program; if not, write to the Free Software
>>>>>> > >> >> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
>>>>>> > >> >> + * 02110-1301 USA
>>>>>> > >> >> + *
>>>>>> > >> >> + */
>>>>>> > >> >> +
>>>>>> > >> >> +#include<linux/interrupt.h>
>>>>>> > >> >> +#include<linux/clk.h>
>>>>> > >> >
>>>>> > >> > why ??
>>>> > >>
>>>> > >> Clock rate setting functions.
>>> > >
>>> > > you shouldn't need in drivers.
>> >
>> > It is a one time setting of the rate so keeping it in drivers.
> you need some other way to handle this. Why do you need to manually set
> the rate rather than having hwmod handle this for you ?
Because hwmod has not idea about what rate a device needs to operate
in any point.
next prev parent reply other threads:[~2011-08-11 14:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1312979122-5896-1-git-send-email-j-keerthy@ti.com>
[not found] ` <1312979122-5896-7-git-send-email-j-keerthy@ti.com>
2011-08-10 12:46 ` [RFC PATCH 6/6] hwmon: OMAP4: On die temperature sensor driver Felipe Balbi
2011-08-11 9:57 ` J, KEERTHY
2011-08-11 10:36 ` Felipe Balbi
2011-08-11 13:00 ` J, KEERTHY
2011-08-11 14:12 ` Felipe Balbi
2011-08-11 14:25 ` Rajendra Nayak [this message]
2011-08-11 14:32 ` J, KEERTHY
2011-08-11 18:54 ` Felipe Balbi
2011-08-11 18:55 ` Felipe Balbi
2011-08-11 21:37 ` Roger Quadros
2011-08-12 1:02 ` J, KEERTHY
2011-08-12 3:26 ` Rajendra Nayak
2011-08-12 8:44 ` Felipe Balbi
2011-08-22 23:58 ` Kevin Hilman
2011-08-23 4:18 ` Rajendra Nayak
2011-08-23 6:42 ` J, KEERTHY
2011-08-23 17:15 ` Kevin Hilman
2011-08-24 4:07 ` Rajendra Nayak
2011-08-11 16:38 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E43E652.5020303@ti.com \
--to=rnayak@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox