Subject: [PATCH 1/7] ARM: l2x0: add empty l2x0_of_init

From: [email-masked] (Rob Herring)
Date: Wed, 31 Aug 2011 22:58:13 -0500

Barry,

On 08/31/2011 10:36 PM, Barry Song wrote:
> 2011/9/1 Rob Herring <[email-masked]>:
>> From: Rob Herring <[email-masked]>
>>
>> Add empty version of l2x0_of_init for when CONFIG_CACHE_L2X0 is not selected.
>>
>> Signed-off-by: Rob Herring <[email-masked]>
> 
> Acked-by: Barry Song <[email-masked]>
> 
Thanks.

> it seems most people use
> "
> #ifdef CONFIG_CACHE_L2X0
> ...
> l2x0 related codes
> ...
> #endif
> "
> or
> "
> obj-$(CONFIG_CACHE_L2X0) += xxx-l2x0.o
> "
> 
> to avoid l2x0 related codes compiled and linked into kernel.
> 
> but this patch provides another option. it is not bad too.
> 

The difference with existing platforms and l2x0_init is the ioremap or
static mapping and latency register setup for pl310 is outside the
function, so you still need an ifdef around all that. With l2x0_of_init,
all the setup is done inside the function, so having an empty version is
useful.

Rob