Subject: [RFC PATCH v2 3/3] ARM: SoC: convert VExpress/RealView to SoC descriptor

From: [email-masked] (Marc Zyngier)
Date: Fri, 09 Sep 2011 16:20:18 +0100

On 09/09/11 15:56, Arnd Bergmann wrote:
> On Friday 09 September 2011, Marc Zyngier wrote:
>> Convert both Realview and VExpress to use the SoC descriptor to
>> provide their SMP and CPU hotplug operation.
>>
>> Cc: Arnd Bergmann <[email-masked]>
>> Cc: Nicolas Pitre <[email-masked]>
>> Signed-off-by: Marc Zyngier <[email-masked]>
> 
> Yes, looks good to me.
> 
>>  }
>> +
>> +struct arm_soc_desc realview_soc_desc __initdata = {
>> +       .name           = "ARM RealView Platform",
>> +#ifdef CONFIG_SMP
>> +       .smp_ops        = &realview_soc_smp_ops,
>> +#endif
>> +};
> 
> Do you think we should have a macro for this? Since this is
> always the same, we could do something like
> 
> #ifdef CONFIG_SMP
> #define soc_smp_ops(ops)	.smp_ops = &(ops),
> #else
> #define soc_smp_ops(ops)	/* empty */
> #endif

That would be an improvement indeed. Will queue that for v3.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...