From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/3] genirq: add support for per-cpu dev_id interrupts
Date: Fri, 30 Sep 2011 12:08:01 +0100 [thread overview]
Message-ID: <4E85A311.5030805@arm.com> (raw)
In-Reply-To: <4E84088C.8050101@codeaurora.org>
On 29/09/11 06:56, Abhijeet Dharmapurikar wrote:
> On 09/23/2011 09:03 AM, Marc Zyngier wrote:
>> The ARM GIC interrupt controller offers per CPU interrupts (PPIs),
>> which are usually used to connect local timers to each core.
>> Each CPU has its own private interface to the GIC,
>> and only sees the PPIs that are directly connect to it.
>>
>> While these timers are separate devices and have a separate
>> interrupt line to a core, they all use the same IRQ number.
>>
>> For these devices, request_irq() is not the right API as it
>> assumes that an IRQ number is visible by a number of CPUs
>> (through the affinity setting), but makes it very awkward to
>> express that an IRQ number can be handled by all CPUs, and
>> yet be a different interrupt line on each CPU, requiring a
>> different dev_id cookie to be passed back to the handler.
>>
>> The *_percpu_irq() functions is designed to overcome these
>> limitations, by providing a per-cpu dev_id vector:
>>
>> int request_percpu_irq(unsigned int irq, irq_handler_t handler,
>> const char *devname, void __percpu *percpu_dev_id);
>> void free_percpu_irq(unsigned int, void __percpu *);
>> int setup_percpu_irq(unsigned int irq, struct irqaction *new);
>> void remove_percpu_irq(unsigned int irq, struct irqaction *act);
>> void enable_percpu_irq(unsigned int irq);
>
> As mentioned here
> https://lkml.org/lkml/2011/9/25/121
>
> can we add irqflags to enable_percpu_irq? This will make msm's
> usage cleaner and it wont have to rely on accessing the gic
> registers outside the driver.
I have the attached patch in my tree (and obviously hacked the
corresponding timer code).
Can you give it a whirl by removing your private GIC configuration and
passing the type to enable_percpu_irq()?
Thanks,
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2011-09-30 11:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-23 16:03 [PATCH v3 0/3] genirq: handling GIC per-cpu interrupts Marc Zyngier
2011-09-23 16:03 ` [PATCH v3 1/3] genirq: add support for per-cpu dev_id interrupts Marc Zyngier
2011-09-29 5:56 ` Abhijeet Dharmapurikar
2011-09-30 11:08 ` Marc Zyngier [this message]
2011-09-23 16:03 ` [PATCH v3 2/3] ARM: gic: consolidate PPI handling Marc Zyngier
2011-09-28 0:59 ` Tony Lindgren
2011-09-23 16:03 ` [PATCH v3 3/3] ARM: gic, local timers: use the request_percpu_irq() interface Marc Zyngier
2011-09-26 20:18 ` [PATCH v3 0/3] genirq: handling GIC per-cpu interrupts David Brown
2011-09-27 0:11 ` David Brown
2011-09-27 10:21 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E85A311.5030805@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox