Subject: [PATCH V2 1/2] ARM: S3C2410: Add __init attribute to usb_simtec_init()

From: [email-masked] (Sergei Shtylyov)
Date: Sat, 08 Oct 2011 18:18:19 +0400

Hello.

On 07-10-2011 15:55, Tushar Behera wrote:

> usb_simtec_init() references s3c_ohci_set_platdata() which is defined
> with __init attribute. Hence to remove section mismatch warning, __init
> attribute is added to usb_simtec_init().

> It removes following two warnigs.

> WARNING: vmlinux.o(.text+0x1460c): Section mismatch in reference from
> the function     usb_simtec_init() to the function
>   .init.text:s3c_ohci_set_platdata()
> The function usb_simtec_init() references the function
>   __init s3c_ohci_set_platdata().

> WARNING: vmlinux.o(.text+0x14650): Section mismatch in reference from
> the function     usb_simtec_init() to the (unknown reference)
> .init.data:(unknown)
> The function usb_simtec_init() references the (unknown reference)
> __initdata (unknown).

> Signed-off-by: Tushar Behera<[email-masked]>
[...]

> diff --git a/arch/arm/mach-s3c2410/usb-simtec.h b/arch/arm/mach-s3c2410/usb-simtec.h
> index 03842ed..43cc88f 100644
> --- a/arch/arm/mach-s3c2410/usb-simtec.h
> +++ b/arch/arm/mach-s3c2410/usb-simtec.h
> @@ -12,5 +12,5 @@
>    * published by the Free Software Foundation.
>   */
>
> -extern int usb_simtec_init(void);
> +extern int __init usb_simtec_init(void);

    Function prototypes don't need to be annotated with __init.

WBR, Sergei