From: lauri.hintsala@bluegiga•com (Lauri Hintsala)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: mxs: Add initial support for Bluegiga APX4 Development Kit
Date: Tue, 18 Oct 2011 12:34:21 +0300 [thread overview]
Message-ID: <4E9D481D.2070905@bluegiga.com> (raw)
In-Reply-To: <20111018075843.GG7761@tarshish>
On 10/18/2011 10:58 AM, Baruch Siach wrote:
> Hi Lauri,
>
> On Tue, Oct 18, 2011 at 10:45:30AM +0300, Lauri Hintsala wrote:
>> On 10/17/2011 01:39 PM, Baruch Siach wrote:
>>> Hi Uwe, Lauri,
>>> On Mon, Oct 17, 2011 at 11:44:34AM +0200, Uwe Kleine-K?nig wrote:
>>>> Hello,
>>>>
>>>> On Mon, Oct 17, 2011 at 11:08:36AM +0300, Lauri Hintsala wrote:
>>>>> Added initial support for Bluegiga APX4 module and Development Kit.
>>>>> Patches are based on Linux v3.1-rc9.
>>>
>>> [snip]
>>>
>>>>> +static int __init apx4devkit_fec_get_mac(char *macstr)
>>>>> +{
>>>>> + int i, h, l;
>>>>> +
>>>>> + macstr++;
>>>>> +
>>>>> + for (i = 0; i< 6; i++) {
>>>>> + if (i != 5&& *(macstr + 2) != ':')
>>>>> + goto error;
>>>>> +
>>>>> + h = hex_to_bin(*macstr++);
>>>>> + if (h == -1)
>>>>> + goto error;
>>>>> +
>>>>> + l = hex_to_bin(*macstr++);
>>>>> + if (l == -1)
>>>>> + goto error;
>>>>> +
>>>>> + macstr++;
>>>>> + mx28_fec_pdata.mac[i] = (h<< 4) + l;
>>>>> + }
>>>>> + return 0;
>>>> I wonder if there isn't a more generic way to parse a mac address.
>>>>
>>>> Other machines put the mac into the otp.
>>>>
>>>>> +error:
>>>>> + pr_err("%s: invalid mac address\n", __func__);
>>>>> + return -EINVAL;
>>>>> +}
>>>>> +
>>>>> +__setup("ethaddr", apx4devkit_fec_get_mac);
>>>> the name is IMHO too generic for a board specific parameter. Think about
>>>> a kernel that runs on all mxs based machines. ethaddr=... only affects
>>>> your machine type. And it's not possible to add the same parameter to a
>>>> different board.
>>>
>>> The fec driver already supports the macaddr module parameter. See the comment
>>> at the beginning of the fec_get_mac() routine in drivers/net/fec.c.
>>
>> We are passing mac address from uboot. Uboot's format is
>> "xx:xx:xx:xx:xx:xx" and fec is getting mac address as array
>> "0x00,0x04,0x9f,0x01,0x30,0xe0". So using fec's routine is not very
>> useful in our case.
>
> u-boot can pass any string you like to the kernel. Just do
Yes I know I can pass any string I like.
> setenv bootargs "$bootargs fec.macaddr=0x00,0x04,0x9f,0x01,0x30,0xe0"
>
> at the u-boot prompt, or in a script.
ethaddr variable of uboot is taking mac addr in colon separated form
(e.g. "00:04.9f:01:30:e0") and it is not very useful to have mac address
in two different form in uboot envs.
Lauri
next prev parent reply other threads:[~2011-10-18 9:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 8:08 [PATCH] ARM: mxs: Add initial support for Bluegiga APX4 Development Kit Lauri Hintsala
2011-10-17 9:44 ` Uwe Kleine-König
2011-10-17 10:39 ` Baruch Siach
2011-10-18 7:45 ` Lauri Hintsala
2011-10-18 7:58 ` Baruch Siach
2011-10-18 9:34 ` Lauri Hintsala [this message]
2011-10-18 12:54 ` Baruch Siach
2011-10-18 7:27 ` Lauri Hintsala
2011-10-18 7:39 ` Uwe Kleine-König
2011-10-18 8:01 ` Lauri Hintsala
2011-10-18 8:12 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9D481D.2070905@bluegiga.com \
--to=lauri.hintsala@bluegiga$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox