From: tim.bird@am•sony.com (Tim Bird)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] Shrink thread_info a bit
Date: Mon, 24 Oct 2011 07:33:15 -0700 [thread overview]
Message-ID: <4EA5772B.1060205@am.sony.com> (raw)
In-Reply-To: <20111024124818.GA17693@n2100.arm.linux.org.uk>
On 10/24/2011 5:48 AM, Russell King - ARM Linux wrote:
> Thread info comes in on Versatile Express at 752 bytes in size, which
> is quite large. Of this, the crunch state is 184 bytes, which is only
> used on Cirrus Logic devices.
>
> It is wasteful to have this in every kernel when Cirrus Logic CPUs
> are not that widely used. So make this conditional.
>
> Signed-off-by: Russell King<rmk+kernel@arm•linux.org.uk>
> ---
> arch/arm/include/asm/thread_info.h | 2 ++
> arch/arm/kernel/asm-offsets.c | 2 ++
> 2 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/include/asm/thread_info.h b/arch/arm/include/asm/thread_info.h
> index 7b5cc8d..a030be7 100644
> --- a/arch/arm/include/asm/thread_info.h
> +++ b/arch/arm/include/asm/thread_info.h
> @@ -59,7 +59,9 @@ struct thread_info {
> __u32 syscall; /* syscall number */
> __u8 used_cp[16]; /* thread used copro */
> unsigned long tp_value;
> +#ifdef CONFIG_CRUNCH
> struct crunch_state crunchstate;
> +#endif
> union fp_state fpstate __attribute__((aligned(8)));
> union vfp_state vfpstate;
> #ifdef CONFIG_ARM_THUMBEE
>
>
Since the asm-offsets.h code already has the offset definitions under
#ifdef CONFIG_CRUNCH, this qualifies as a code consistency cleanup,
as well as a memory savings.
I looked at this, and can find no code outside of #ifdef CONFIG_CRUNCH
that references this - so FWIW
Reviewed-by Tim Bird <tim.bird@am•sony.com>
-- Tim
prev parent reply other threads:[~2011-10-24 14:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 12:48 [PATCH] Shrink thread_info a bit Russell King - ARM Linux
2011-10-24 13:06 ` Baruch Siach
2011-10-24 13:08 ` Russell King - ARM Linux
2011-10-24 13:18 ` Will Deacon
2011-10-24 13:20 ` Russell King - ARM Linux
2011-10-25 14:41 ` Dave Martin
2011-10-26 7:11 ` Will Deacon
2011-10-24 14:33 ` Tim Bird [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA5772B.1060205@am.sony.com \
--to=tim.bird@am$(echo .)sony.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox