Subject: [PATCH 4/4] ARM: exynos4: remove useless code to save/restore L2 and GIC state

From: [email-masked] (Sylwester Nawrocki)
Date: Fri, 04 Nov 2011 18:33:50 +0100

On 11/04/2011 06:03 PM, amit.kachhap at linaro.org wrote:
> From: Amit Daniel Kachhap <[email-masked]>
> 
> Following the merge of CPU PM notifiers and L2 resume code, this patch
> removes useless code to save and restore L2 and GIC registers.
> 
> This is now automatically covered by suspend calls which integrated
> CPU PM notifiers and new sleep code that allows to resume L2 before MMU
> is turned on.
> 
> Signed-off-by: Lorenzo Pieralisi <[email-masked]>
> Signed-off-by: Amit Daniel Kachhap <[email-masked]>
> ---
>  arch/arm/mach-exynos4/pm.c |   86 --------------------------------------------
>  1 files changed, 0 insertions(+), 86 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos4/pm.c b/arch/arm/mach-exynos4/pm.c
> index 62e4f43..7499f14 100644
> --- a/arch/arm/mach-exynos4/pm.c
> +++ b/arch/arm/mach-exynos4/pm.c
> @@ -63,77 +63,6 @@ static struct sleep_save exynos4_vpll_save[] = {
>  };
>  
>  static struct sleep_save exynos4_core_save[] = {
> -	/* GIC side */
> -	SAVE_ITEM(S5P_VA_GIC_CPU + 0x000),
> -	SAVE_ITEM(S5P_VA_GIC_CPU + 0x004),
> -	SAVE_ITEM(S5P_VA_GIC_CPU + 0x008),
> -	SAVE_ITEM(S5P_VA_GIC_CPU + 0x00C),
> -	SAVE_ITEM(S5P_VA_GIC_CPU + 0x014),
> -	SAVE_ITEM(S5P_VA_GIC_CPU + 0x018),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x000),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x004),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x100),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x104),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x108),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x300),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x304),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x308),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x400),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x404),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x408),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x40C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x410),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x414),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x418),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x41C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x420),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x424),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x428),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x42C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x430),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x434),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x438),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x43C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x440),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x444),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x448),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x44C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x450),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x454),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x458),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x45C),
> -
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x800),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x804),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x808),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x80C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x810),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x814),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x818),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x81C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x820),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x824),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x828),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x82C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x830),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x834),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x838),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x83C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x840),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x844),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x848),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x84C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x850),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x854),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x858),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0x85C),
> -
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0xC00),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0xC04),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0xC08),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0xC0C),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0xC10),
> -	SAVE_ITEM(S5P_VA_GIC_DIST + 0xC14),

This list is not complete anyway, some peripheral devices interrupts do not
work after resume from system suspend to RAM.
Is there any code already handling GIC state during system suspend/resume cycles?
Or you refer to some upcoming patches ?

--
Thanks,
Sylwester