Subject: [PATCH v7 11/21] OMAP2+: UART: Move errata handling from serial.c to omap-serial

From: [email-masked] (Shubhrajyoti)
Date: Fri, 11 Nov 2011 11:41:36 +0530

On Friday 11 November 2011 05:14 AM, Jon Hunter wrote:
> Hi Govindraj,
>
> On 10/18/2011 10:26, Govindraj.R wrote:
>> Move the errata handling mechanism from serial.c to omap-serial file
>> and utilise the same func in driver file.
>>
>> Errata i202, i291 are moved to be handled with omap-serial
>> Moving the errata macro from serial.c file to driver header file
>> as from on errata will be handled in driver file itself.
>> Corrected errata id from chapter reference 2.15 to errata id i291.
>>
>> Removed errata and dma_enabled feilds from omap_uart_state struct
Nitpick.
The field spelling could be corrected.
>> as they are no more needed with errata handling done within omap-serial.
>>
>> Acked-by: Alan Cox<[email-masked]>
>> Signed-off-by: Govindraj.R<[email-masked]>
>> ---
>>   arch/arm/mach-omap2/serial.c                  |   97
>> +++++++------------------
>>   arch/arm/plat-omap/include/plat/omap-serial.h |    6 ++
>>   drivers/tty/serial/omap-serial.c              |   66 ++++++++++++++++-
>>   3 files changed, 95 insertions(+), 74 deletions(-)
>
> [snip]
>
>> +    /* Enable the MDR1 errata for OMAP3 */
>> +    if (cpu_is_omap34xx()&&  !cpu_is_ti816x())
>> +        omap_up.errata |= UART_ERRATA_i202_MDR1_ACCESS;
>
> This errata (i202) is applicable to all devices from OMAP2430 to
> OMAP4460 (apparently this one is not getting fixed). So could you make
> sure this is enabled for 2430, 3430, 3630, 4430 and 4460?
>
Yes good point.

> [snip]
>
>> +/*
>> + * Work Around for Errata i202 (3430 - 1.12, 3630 - 1.6)
>
> We should update the comment to be "Work Around for Errata i202 (2430,
> 3430, 3630, 4430 and 4460)". The "1.12" and "1.6" are just the section
> references in the errata docs, but I think that you can drop these as
> you can just search for the errata ID which is i202.
>
> Cheers
> Jon
>
>
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html