From: marc.zyngier@arm•com (Marc Zyngier)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] ARM: EXYNOS4: convert MCT to percpu interrupt API
Date: Fri, 11 Nov 2011 10:02:37 +0000 [thread overview]
Message-ID: <4EBCF2BD.8050804@arm.com> (raw)
In-Reply-To: <CAJ0PZbRKcnVwCGsYrMYr39O2S9rTRbX3MzXVW5nQs=MhYi_FQQ@mail.gmail.com>
On 10/11/11 23:33, MyungJoo Ham wrote:
> On Thu, Nov 10, 2011 at 6:43 PM, Marc Zyngier <marc.zyngier@arm•com> wrote:
>> On 10/11/11 02:40, MyungJoo Ham wrote:
>>> On Thu, Nov 3, 2011 at 2:30 AM, Marc Zyngier <marc.zyngier@arm•com> wrote:
>>>> MCT recently gained per cpu interrupts, and missed the fact that
>>>> ARM has moved to a genirq based implementation.
>>>>
>>>> This patch converts the driver to the new API.
>>>>
>>>> Boot tested on Origen.
>>>>
>>>> Cc: Kukjin Kim <kgene.kim@samsung•com>
>>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm•com>
>>>
>>> There is one concern regarding the CONFIG_LOCAL_TIMER.
>>>
>>> []
>>>> #endif /* CONFIG_LOCAL_TIMERS */
>>>>
>>>> static void __init exynos4_timer_resources(void)
>>>> @@ -438,6 +442,16 @@ static void __init exynos4_timer_resources(void)
>>>> mct_clk = clk_get(NULL, "xtal");
>>>>
>>>> clk_rate = clk_get_rate(mct_clk);
>>>> +
>>>> + if (mct_int_type == MCT_INT_PPI) {
>>>> + int err;
>>>> +
>>>> + err = request_percpu_irq(IRQ_MCT_LOCALTIMER,
>>>> + exynos4_mct_tick_isr, "MCT",
>>>> + &percpu_mct_tick);
>>>> + WARN(err, "MCT: can't request IRQ %d (%d)\n",
>>>> + IRQ_MCT_LOCALTIMER, err);
>>>> + }
>>>> }
>>>>
>>>
>>> You've added exynos4_mct_tick_isr, which is defined in
>>> CONFIG_LOCAL_TIMER section, in the place that is compiled without
>>> CONFIG_LOCAL_TIMER.
>>> I guess we are going to stop supporting LOCAL_TIMER in Exynos later
>>> and this could be a problem with it.
>>
>> Yup, this is a problem. It probably means we need to #ifdef that chink
>> as well. I'm not sure I get your remark about not supporting LOCAL_TIMER
>> though. Are you planning to move away from the LOCAL_TIMER infrastructure?
>
> Yes, we may need to #ifdef that block.
> And yes, for the Exynos series, I'll need to double check; however, I
> think we are planning to move away from the LOCAL_TIMER for MCT.
I have patches for this already.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2011-11-11 10:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 17:30 [PATCH 0/2] PPI fixes for 3.2 Marc Zyngier
2011-11-02 17:30 ` [PATCH 1/2] ARM: EXYNOS4: convert MCT to percpu interrupt API Marc Zyngier
2011-11-03 6:27 ` Kukjin Kim
2011-11-10 2:40 ` MyungJoo Ham
2011-11-10 9:43 ` Marc Zyngier
2011-11-10 23:33 ` MyungJoo Ham
2011-11-11 10:02 ` Marc Zyngier [this message]
2011-11-02 17:30 ` [PATCH 2/2] ARM: mcx: fix local timer interrupt handling Marc Zyngier
2011-11-02 18:27 ` Uwe Kleine-König
2011-11-03 4:35 ` Shawn Guo
2011-11-03 6:55 ` Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBCF2BD.8050804@arm.com \
--to=marc.zyngier@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox