Subject: [PATCH v5 07/11] davinci: dm644x: Replace register base value with a defined macro

From: [email-masked] (Sergei Shtylyov)
Date: Wed, 14 Dec 2011 14:36:41 +0400

Hello.

On 13-12-2011 15:23, Manjunath Hadli wrote:

> Replace hard coded value of vpss register base to a define macro
> DM644X_VPSS_REG_BASE for proper readability

> Signed-off-by: Manjunath Hadli<[email-masked]>
> Acked-by: Sekhar Nori<[email-masked]>
> ---
>   arch/arm/mach-davinci/dm644x.c |    8 +++++---
>   1 files changed, 5 insertions(+), 3 deletions(-)

> diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c
> index 6b1d473..3802b59 100644
> --- a/arch/arm/mach-davinci/dm644x.c
> +++ b/arch/arm/mach-davinci/dm644x.c
> @@ -594,13 +594,15 @@ static struct platform_device dm644x_asp_device = {
>   	.resource	= dm644x_asp_resources,
>   };
>
> +#define DM644X_VPSS_REG_BASE	0x01c73400
> +

    Why not simply DM644X_VPSS_BASE, like all the other #define's?

WBR, Sergei