From: sshtylyov@mvista•com (Sergei Shtylyov)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v5 10/11] davinci: dm644x: add support for v4l2 video display
Date: Wed, 14 Dec 2011 14:48:40 +0400 [thread overview]
Message-ID: <4EE87F08.6080309@mvista.com> (raw)
In-Reply-To: <1323775415-24504-11-git-send-email-manjunath.hadli@ti.com>
Hello.
On 13-12-2011 15:23, Manjunath Hadli wrote:
> Create platform devices for various video modules like venc,osd,
> vpbe and v4l2 driver for dm644x. Change the dm644x_init_video to
> make room for display config, and register the vpfe or vpbe devices
> based on the config pointer validity to make sure boards without vpfe
> or vpbe can be built with minimal changes.
> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti•com>
[...]
> diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c
> index 6c034fd..2e408d8 100644
> --- a/arch/arm/mach-davinci/dm644x.c
> +++ b/arch/arm/mach-davinci/dm644x.c
[...]
> @@ -654,7 +654,127 @@ static struct platform_device dm644x_vpfe_dev = {
[...]
> +#define DM644X_OSD_REG_BASE 0x01c72600
[...]
> +#define DM644X_VENC_REG_BASE 0x01c72400
Why not without _REG, like all the other #define's?
> +static int dm644x_venc_setup_clock(enum vpbe_enc_timings_type type,
> + unsigned int mode)
> +{
> + int ret = 0;
> + void __iomem *vpss_clkctl_reg;
> +
> + vpss_clkctl_reg = DAVINCI_SYSMODULE_VIRT(0x44);
Why not in the initializer?
> + switch (type) {
> + case VPBE_ENC_STD:
> + writel(0x18, vpss_clkctl_reg);
> + break;
> + case VPBE_ENC_DV_PRESET:
> + switch ((unsigned int)mode) {
'mode' is already 'unsigned int'.
WBR, Sergei
next prev parent reply other threads:[~2011-12-14 10:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 11:23 [PATCH v5 00/11]ARM: davinci:add support for dm644x vpbe display driver Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 01/11] davinci: vpif: remove obsolete header file inclusion Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 02/11] ARM: davinci: dm644x: remove the macros from the header to move to c file Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 03/11] ARM: davinci: dm365: " Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 04/11] ARM: davinci: dm646x: " Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 05/11] ARM: davinci: create new common platform header for davinci Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 06/11] davinci: eliminate use of IO_ADDRESS() on sysmod Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 07/11] davinci: dm644x: Replace register base value with a defined macro Manjunath Hadli
2011-12-14 10:36 ` Sergei Shtylyov
2011-12-15 11:11 ` Hadli, Manjunath
2011-12-13 11:23 ` [PATCH v5 08/11] davinci: dm644x: change vpfe capture structure variables for consistency Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 09/11] davinci: dm644x: move vpfe init from soc to board specific files Manjunath Hadli
2011-12-13 11:23 ` [PATCH v5 10/11] davinci: dm644x: add support for v4l2 video display Manjunath Hadli
2011-12-14 10:48 ` Sergei Shtylyov [this message]
2011-12-15 11:13 ` Hadli, Manjunath
2011-12-13 11:23 ` [PATCH v5 11/11] davinci: dm644x EVM: add support for VPBE display Manjunath Hadli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE87F08.6080309@mvista.com \
--to=sshtylyov@mvista$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox