From: shubhrajyoti@ti•com (Shubhrajyoti)
To: linux-arm-kernel@lists•infradead.org
Subject: [GIT PULL] ARM: OMAP: I2C: prepare to use hwmod reset in driver
Date: Sun, 18 Dec 2011 13:31:24 +0530 [thread overview]
Message-ID: <4EED9DD4.3020506@ti.com> (raw)
In-Reply-To: <20111217002409.GB6464@atomide.com>
On Saturday 17 December 2011 05:54 AM, Tony Lindgren wrote:
> * Paul Walmsley <paul@pwsan•com> [111216 12:27]:
>> Hi
>>
>> On Fri, 16 Dec 2011, Tony Lindgren wrote:
>>
>>> * Paul Walmsley <paul@pwsan•com> [111216 11:45]:
>>>> On Fri, 16 Dec 2011, Tony Lindgren wrote:
>>>>
>>>>> * Paul Walmsley <paul@pwsan•com> [111216 01:24]:
>>>>>
>>>>>> Shubhrajyoti D (2):
>>>>>> ARM: OMAP: omap_device: add omap_device_reset to reset all the hwmods in the device
>>>>>> ARM: OMAP: I2C: Reset support
>>>>>>
>>>>> Can you please update shi to leave out the extra callback
>>>>> function int (*device_reset) (struct device *dev) as I'd
>>>>> rather see that happen with pm_runtime calls?
>>>> What PM runtime call is used to reset a device?
>>> Hmm how about pm_runtime_disable? Or do we need a new
>>> call for reset?
> Meanwhile as Paul pointed out, we still need the device_reset
> pointer, so pulling in this series into i2c branch.
>
>> Looking at the last few hunks of:
>>
>> http://marc.info/?l=linux-omap&m=132377389204328&w=2
>>
>> it appears to me that the driver needs to reset the device while it's
>> still active & powered on, etc.
>>
>> Shubhrajyoti, care to comment further?
The driver does a reset in the error path.
Since we are not supposed to access the sysc reg the function is needed.
>>
>> - Paul
next prev parent reply other threads:[~2011-12-18 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 9:55 [GIT PULL] ARM: OMAP: I2C: prepare to use hwmod reset in driver Paul Walmsley
2011-12-16 19:50 ` Tony Lindgren
2011-12-16 20:17 ` Paul Walmsley
2011-12-16 20:41 ` Tony Lindgren
2011-12-16 20:59 ` Paul Walmsley
2011-12-17 0:24 ` Tony Lindgren
2011-12-18 8:01 ` Shubhrajyoti [this message]
2011-12-19 16:32 ` Cousson, Benoit
2011-12-19 17:37 ` Shubhrajyoti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EED9DD4.3020506@ti.com \
--to=shubhrajyoti@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox