From: grinberg@compulab•co.il (Igor Grinberg)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] OMAP3: hwmod_data: register dss hwmods after dss_core
Date: Thu, 22 Dec 2011 17:10:42 +0200 [thread overview]
Message-ID: <4EF34872.4030700@compulab.co.il> (raw)
In-Reply-To: <1324562563-27119-1-git-send-email-yanok@emcraft.com>
Hi Ilya,
Thanks for the patch.
On 12/22/11 16:02, Ilya Yanok wrote:
> dss_core has to be initialized before any other DSS hwmod. Currently
> this is broken as dss_core is listed in chip/revision specific hwmod
> lists while other DSS hwmods are listed in common list which is
> registered first.
>
> This patch moves DSS hwmods (except for dss_core) to the separate list
> which is registered last to ensure that dss_core is already registered.
I would suggest to add an in-code comment for this
(more descriptive, than the one you did for that patch),
and describe the otherwise breakage, so next time it would be
a bit harder to break that thing...
>
> CC: Tomi Valkeinen <tomi.valkeinen@ti•com>
> CC: Archit Taneja <archit@ti•com>
> CC: Paul Walmsley <paul@pwsan•com>
> Signed-off-by: Ilya Yanok <yanok@emcraft•com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 20 ++++++++++++++------
> 1 files changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 5324e8d..85536ff 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -3523,12 +3523,6 @@ static __initdata struct omap_hwmod *omap3xxx_hwmods[] = {
> &omap3xxx_uart2_hwmod,
> &omap3xxx_uart3_hwmod,
>
> - /* dss class */
> - &omap3xxx_dss_dispc_hwmod,
> - &omap3xxx_dss_dsi1_hwmod,
> - &omap3xxx_dss_rfbi_hwmod,
> - &omap3xxx_dss_venc_hwmod,
> -
> /* i2c class */
> &omap3xxx_i2c1_hwmod,
> &omap3xxx_i2c2_hwmod,
> @@ -3635,6 +3629,15 @@ static __initdata struct omap_hwmod *am35xx_hwmods[] = {
> NULL
> };
>
> +static __initdata struct omap_hwmod *omap3xxx_dss_hwmods[] = {
> + /* dss class */
> + &omap3xxx_dss_dispc_hwmod,
> + &omap3xxx_dss_dsi1_hwmod,
> + &omap3xxx_dss_rfbi_hwmod,
> + &omap3xxx_dss_venc_hwmod,
> + NULL
> +};
> +
> int __init omap3xxx_hwmod_init(void)
> {
> int r;
> @@ -3708,6 +3711,11 @@ int __init omap3xxx_hwmod_init(void)
>
> if (h)
> r = omap_hwmod_register(h);
> + if (r < 0)
> + return r;
> +
> + /* Register common DSS hwmods later than dss_core */
> + r = omap_hwmod_register(omap3xxx_dss_hwmods);
>
> return r;
> }
--
Regards,
Igor.
next prev parent reply other threads:[~2011-12-22 15:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 14:02 [PATCH] OMAP3: hwmod_data: register dss hwmods after dss_core Ilya Yanok
2011-12-22 15:10 ` Igor Grinberg [this message]
2011-12-27 23:31 ` [PATCH V2] " Ilya Yanok
2011-12-30 10:02 ` Archit Taneja
2012-01-11 21:19 ` Ilya Yanok
2012-01-12 9:13 ` Tomi Valkeinen
2012-01-25 21:23 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF34872.4030700@compulab.co.il \
--to=grinberg@compulab$(echo .)co.il \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox