From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3] ARM: at91: pit add DT support
Date: Fri, 06 Jan 2012 14:36:42 +0100 [thread overview]
Message-ID: <4F06F8EA.30104@atmel.com> (raw)
In-Reply-To: <4F05D2F3.40704@gmail.com>
On 01/05/2012 05:42 PM, Rob Herring :
> On 01/05/2012 11:25 AM, Nicolas Ferre wrote:
>> From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
>>
>> Retreive registers address and IRQ from device tree entry. Fall back
>> to built-in values if an error occurs.
>>
>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft•com>
>> [nicolas.ferre at atmel.com: change error path and interrupts property handling]
>> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel•com>
>> ---
>> v3: - use irq_of_parse_and_map() for handling irq numbers specified by DT.
>> Correction proposed by Jamie Iles.
>>
>> v2: - new specification of irq numbers in DT (due to modification of AIC code)
>> - new error path in of_at91sam926x_pit_init()
>> - fall back to built-in values if an error occurs
>> - use of of_property_read_u32() to get irq property
>>
>> .../devicetree/bindings/arm/atmel-at91.txt | 8 +++
>> arch/arm/boot/dts/at91sam9g20.dtsi | 5 ++
>> arch/arm/boot/dts/at91sam9g45.dtsi | 6 ++
>> arch/arm/mach-at91/at91sam926x_time.c | 53 +++++++++++++++++++-
>> 4 files changed, 70 insertions(+), 2 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/arm/atmel-at91.txt
[..]
>> --- a/arch/arm/mach-at91/at91sam926x_time.c
>> +++ b/arch/arm/mach-at91/at91sam926x_time.c
[..]
>> void __init at91sam926x_ioremap_pit(u32 addr)
>> {
>> + if (!of_at91sam926x_pit_init())
>> + return;
>
> This seems backwards to me. I don't have the ioremap changes in my tree,
> but shouldn't the caller of at91sam926x_ioremap_pit be changed to
> something like this:
>
> if (of_at91sam926x_pit_init() < 0)
> at91sam926x_ioremap_pit(addr);
Yes, you are right, it will be more readable the other way around.
I repost another revision now.
> Otherwise,
> Acked-by: Rob Herring <rob.herring@calxeda•com>
Thanks for your review.
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-01-06 13:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20111016210819.GM1459@game.jcrosoft.org>
2011-10-16 21:18 ` [PATCH 1/4] ARM: at91: add at91sam9g20 dtsi Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 21:18 ` [PATCH 2/4] ARM: at91: add Calao USB A9G20 DT support Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 21:18 ` [PATCH 3/4] ARM: at91/smc: add " Jean-Christophe PLAGNIOL-VILLARD
2011-10-16 21:18 ` [PATCH 4/4] ARM: at91/pit: " Jean-Christophe PLAGNIOL-VILLARD
2012-01-05 13:48 ` [PATCH v2] ARM: at91: pit " Nicolas Ferre
2012-01-05 12:00 ` Jamie Iles
2012-01-05 14:50 ` Nicolas Ferre
2012-01-05 14:56 ` Jamie Iles
2012-01-05 17:25 ` [PATCH v3] " Nicolas Ferre
2012-01-05 15:34 ` Jamie Iles
2012-01-05 16:42 ` Rob Herring
2012-01-06 13:36 ` Nicolas Ferre [this message]
2012-01-05 18:00 ` Grant Likely
2012-01-06 13:37 ` Nicolas Ferre
2012-01-06 16:20 ` [PATCH v4] " Nicolas Ferre
2012-01-06 15:47 ` Rob Herring
2012-01-06 17:28 ` Nicolas Ferre
2012-01-09 17:39 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-10 8:34 ` Nicolas Ferre
2012-02-22 14:32 ` [PATCH v5 1/2] " Nicolas Ferre
2012-02-22 14:32 ` [PATCH v5 2/2] ARM: at91/pit: add traces in case of error Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F06F8EA.30104@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox