From: b-cousson@ti•com (Cousson, Benoit)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] irqdomain: Initialize number of IRQs for simple domains
Date: Fri, 6 Jan 2012 17:58:43 +0100 [thread overview]
Message-ID: <4F072843.6050306@ti.com> (raw)
In-Reply-To: <1325860112-22051-1-git-send-email-thierry.reding@avionic-design.de>
Hi Thierry,
On 1/6/2012 3:28 PM, Thierry Reding wrote:
> The irq_domain_add() function needs the number of interrupts in the
> domain to properly initialize them. In addition the allocated domain
> is now returned by the irq_domain_{add,generate}_simple() helpers.
[...]
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index d587560..bf67781 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -66,8 +66,11 @@ static struct of_device_id intc_match[] __initdata = {
> static void __init omap_generic_init(void)
> {
> struct device_node *node = of_find_matching_node(NULL, intc_match);
> - if (node)
> - irq_domain_add_simple(node, 0);
> + if (node) {
> + struct irq_domain *domain;
> + domain = irq_domain_add_simple(node, 0, INTCPS_NR_IRQS);
The number of interrupts will depend on the OMAP generation. That one is
just valid for the 3430 INTC controller.
Since the previous code was using zero, I guess that using 0 there
should be fine.
Moreover, that piece of code should not exist anymore on 3.3 if the
series I sent last month to leverage Rob's DT interrupt init is merged [1].
I've just ping Rob and Grant on that series to get a status.
Regards,
Benoit
[1] http://www.spinics.net/lists/linux-omap/msg62124.html
next prev parent reply other threads:[~2012-01-06 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-06 14:28 [PATCH] irqdomain: Initialize number of IRQs for simple domains Thierry Reding
2012-01-06 14:36 ` Nicolas Ferre
2012-01-06 15:04 ` Grant Likely
2012-01-06 16:20 ` Thierry Reding
2012-01-06 21:34 ` Grant Likely
2012-01-07 11:40 ` Thierry Reding
2012-01-06 16:07 ` David Brown
2012-01-06 16:12 ` Thierry Reding
2012-01-06 16:26 ` Rob Herring
2012-01-06 18:52 ` David Brown
2012-01-06 16:58 ` Cousson, Benoit [this message]
2012-01-09 9:03 ` Thierry Reding
2012-01-07 5:58 ` Shawn Guo
2012-01-07 11:47 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F072843.6050306@ti.com \
--to=b-cousson@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox