From: robherring2@gmail•com (Rob Herring)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/6] ARM: exynos: remove incorrect BSYM usage
Date: Wed, 11 Jan 2012 09:32:05 -0600 [thread overview]
Message-ID: <4F0DAB75.7020006@gmail.com> (raw)
In-Reply-To: <1326149146-19756-2-git-send-email-robherring2@gmail.com>
On 01/09/2012 04:45 PM, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda•com>
>
> BSYM macro is only needed for assembly files and its usage in c files is
> wrong, so remove it. The linker will correctly set bit 0 for Thumb2
> kernels.
>
> Signed-off-by: Rob Herring <rob.herring@calxeda•com>
> Cc: Dave Martin <dave.martin@linaro•org>
> Cc: Kukjin Kim <kgene.kim@samsung•com>
> ---
This needs an ENDPROC as well for exynos4_secondary_startup. And so do
msm and ux500 as well.
Rob
> arch/arm/mach-exynos/platsmp.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/platsmp.c b/arch/arm/mach-exynos/platsmp.c
> index 60bc45e..683aec7 100644
> --- a/arch/arm/mach-exynos/platsmp.c
> +++ b/arch/arm/mach-exynos/platsmp.c
> @@ -24,7 +24,6 @@
> #include <asm/cacheflush.h>
> #include <asm/hardware/gic.h>
> #include <asm/smp_scu.h>
> -#include <asm/unified.h>
>
> #include <mach/hardware.h>
> #include <mach/regs-clock.h>
> @@ -137,7 +136,7 @@ int __cpuinit boot_secondary(unsigned int cpu, struct task_struct *idle)
> while (time_before(jiffies, timeout)) {
> smp_rmb();
>
> - __raw_writel(BSYM(virt_to_phys(exynos4_secondary_startup)),
> + __raw_writel(virt_to_phys(exynos4_secondary_startup),
> CPU1_BOOT_REG);
> gic_raise_softirq(cpumask_of(cpu), 1);
>
> @@ -192,6 +191,6 @@ void __init platform_smp_prepare_cpus(unsigned int max_cpus)
> * until it receives a soft interrupt, and then the
> * secondary CPU branches to this address.
> */
> - __raw_writel(BSYM(virt_to_phys(exynos4_secondary_startup)),
> + __raw_writel(virt_to_phys(exynos4_secondary_startup),
> CPU1_BOOT_REG);
> }
next prev parent reply other threads:[~2012-01-11 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:45 [PATCH 0/6] BSYM macro removal Rob Herring
2012-01-09 22:45 ` [PATCH 1/6] ARM: exynos: remove incorrect BSYM usage Rob Herring
2012-01-11 15:32 ` Rob Herring [this message]
2012-01-09 22:45 ` [PATCH 2/6] ARM: realview: " Rob Herring
2012-01-09 22:45 ` [PATCH 3/6] ARM: vexpress: " Rob Herring
2012-01-10 12:04 ` Dave Martin
2012-01-11 15:19 ` Rob Herring
2012-01-09 22:45 ` [PATCH 4/6] ARM: imx: " Rob Herring
2012-01-10 3:16 ` Shawn Guo
2012-01-09 22:45 ` [PATCH 5/6] ARM: highbank: " Rob Herring
2012-01-09 22:45 ` [PATCH 6/6] ARM: make BSYM macro assembly only Rob Herring
2012-01-13 14:03 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0DAB75.7020006@gmail.com \
--to=robherring2@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox