From: jochen@scram•de (Jochen Friedrich)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2] ARM: sa1100: Refactor mcp-sa11x0 to use platform resources.
Date: Wed, 18 Jan 2012 12:30:13 +0100 [thread overview]
Message-ID: <4F16AD45.6030906@scram.de> (raw)
In-Reply-To: <20120117201256.GV1068@n2100.arm.linux.org.uk>
Hi Russell,
>> Accessing some random SoC registers and in the assabet case even board
>> specific registers from device drivers is even worse IMHO. We don't get
>> a clean solution until we have a pinmux/pinctrl device driver owning
>> these peripheral control registers. At least having the setup in the
>> board files avoids a potential race condition accessing PPDR and PPSR
>> registers from multiple drivers.
>
> Yes, but do we really need the exact same code repeated time and time
> again in each different board file? Could we not have a function which
> sets the pins up for MCP?
Yes, this would be a good idea. One should do the same for the sa1100
serial driver. Here we even have the bug that the driver unconditionally
sets up pins for UART1 and 3 no matter what platform devices are present.
> I'm not complaining about this one - the MCCR1 shares its 64K space with
> the peripheral pin controller, and I suspect we won't get to the point
> where that's controlled by a driver.
Why not? gpio-generic should be able to handle the PPC registers out of
the box.
Thanks,
Jochen
next prev parent reply other threads:[~2012-01-18 11:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 21:00 [PATCH 1/2] ARM: sa11x0: Implement autoloading of codec and codec pdata for mcp bus Jochen Friedrich
2011-11-27 21:00 ` [PATCH 2/2] ARM: sa1100: Refactor mcp-sa11x0 to use platform resources Jochen Friedrich
2012-01-14 9:21 ` Russell King - ARM Linux
2012-01-17 9:41 ` Jochen Friedrich
2012-01-17 20:12 ` Russell King - ARM Linux
2012-01-18 11:30 ` Jochen Friedrich [this message]
2012-01-18 11:48 ` Russell King - ARM Linux
2011-12-12 17:44 ` [PATCH 1/2] ARM: sa11x0: Implement autoloading of codec and codec pdata for mcp bus Samuel Ortiz
2012-01-18 15:21 ` Russell King - ARM Linux
2012-01-20 17:11 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F16AD45.6030906@scram.de \
--to=jochen@scram$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox