From: nicolas.ferre@atmel•com (Nicolas Ferre)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/1] ARM: Developed device driver for Atmel TSADC controller
Date: Mon, 23 Jan 2012 12:52:14 +0100 [thread overview]
Message-ID: <4F1D49EE.6020600@atmel.com> (raw)
In-Reply-To: <20120123113647.GX1068@n2100.arm.linux.org.uk>
On 01/23/2012 12:36 PM, Russell King - ARM Linux :
> On Mon, Jan 23, 2012 at 12:25:06PM +0100, Petter Nordby wrote:
>> Some Atmel AT91 devices contains a touchscreen analog to digital
>> converter. This device driver use the ADC as a multi-channel raw
>> data input device.
>>
>> Tested on AT91SAM9G45 boards.
>>
>> Signed-off-by: Petter Nordby <pettno@gmail•com>
>> ---
>> CREDITS | 4 +
>
> Shouldn't this be in MAINTAINERS?
>
>> arch/arm/configs/at91sam9g45_defconfig | 1 +
>> arch/arm/mach-at91/include/mach/at91_adc.h | 16 ++
>> drivers/misc/Kconfig | 7 +
>> drivers/misc/Makefile | 1 +
>> drivers/misc/atmel_tsadc.c | 361 ++++++++++++++++++++++++++++
>
> We have a proper abstraction of input devices under drivers/input which
> includes touchscreens. I suggest using that rather than developing
> your own private kernel API.
Petter,
Be sure that I appreciate the submission of your work. Examples of code
and new drivers are always a big strength of the Open Source community.
But as Russell suggested, this use of ADC for AT91SAM9G45 family (TSADC)
will be better suited for the IIO subsystem.
A new AT91 ADC driver designed for this IIO subsystem has been developed
a little time ago:
"[PATCH RESEND v13] AT91: Add a driver for the ADC"
It will likely be included shortly in mainline kernel. I advice to
follow this development and add the support of SAM9G45 ADC to this
existing infrastructure.
I guess that the input/touchsreen part of the TSADC is not the purpose
of your driver:
drivers/input/touchscreen/atmel_tsadcc.c
will take care of this feature.
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2012-01-23 11:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 11:25 [PATCH 1/1] ARM: Developed device driver for Atmel TSADC controller Petter Nordby
2012-01-23 11:36 ` Russell King - ARM Linux
2012-01-23 11:52 ` Nicolas Ferre [this message]
2012-01-23 13:07 ` Petter Nordby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1D49EE.6020600@atmel.com \
--to=nicolas.ferre@atmel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox