From: dh09.lee@samsung•com (Donghwa Lee)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v7 1/2] video: support MIPI-DSI controller driver
Date: Wed, 25 Jan 2012 09:14:58 +0900 [thread overview]
Message-ID: <4F1F4982.5050000@samsung.com> (raw)
In-Reply-To: <20120120155121.18880dff.akpm@linux-foundation.org>
On Sat, 21 Jan 2012 08:51, Andrew Morton wrote:
> On Thu, 19 Jan 2012 20:08:07 +0530
> Archit <a0393947@ti•com> wrote:
>
>> On Thursday 19 January 2012 10:58 AM, Donghwa Lee wrote:
>>> Samsung S5PC210 and EXYNOS SoC platform has MIPI-DSI controller and MIPI-DSI
>>> based LCD Panel could be used with it. This patch supports MIPI-DSI driver
>>> based Samsung SoC chip.
>>>
>>> LCD panel driver based MIPI-DSI should be registered to MIPI-DSI driver at
>>> machine code and LCD panel driver specific function registered to mipi_dsim_ddi
>>> structure at lcd panel init function called system init.
>>> In the MIPI-DSI driver, find lcd panel driver by using registered
>>> lcd panel name, and then initialize lcd panel driver.
>>>
>>> Changes since v6:
>>> - remove obscure compile problems.
>>> - remove useless codes.
>>> - modify return errno codes properly
>>
>> One more comment about 'mipi_dsim.h', it would be better to put it in
>> include/video and not 'include/linux'.
>
> Yes, that is desirable.
>
>>> ---
>>> drivers/video/Kconfig | 6 +
>>> drivers/video/Makefile | 2 +
>>> drivers/video/s5p_mipi_dsi.c | 599 ++++++++++++++++++++++
>>> drivers/video/s5p_mipi_dsi_common.c | 896 +++++++++++++++++++++++++++++++++
>>> drivers/video/s5p_mipi_dsi_common.h | 46 ++
>>> drivers/video/s5p_mipi_dsi_lowlevel.c | 617 +++++++++++++++++++++++
>>> drivers/video/s5p_mipi_dsi_lowlevel.h | 112 ++++
>>> drivers/video/s5p_mipi_dsi_regs.h | 149 ++++++
>>> include/linux/mipi_dsim.h | 359 +++++++++++++
>>> 9 files changed, 2786 insertions(+), 0 deletions(-)
>
> or we could put it in drivers/video/. It all depends on which other
> drivers we expect will need access to this header.
>
No, mipi_dsim.h file includes global interface data, callback function called by machine
file, platform data for mipi-dsi driver and so on. So I think it would be better to put
in 'include/video' or 'include/linux'.
Of course it is much better to change name to 's5p_mipi_dsim.h'
Thank you,
Donghwa Lee
next prev parent reply other threads:[~2012-01-25 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 5:28 [PATCH v7 1/2] video: support MIPI-DSI controller driver Donghwa Lee
2012-01-19 9:56 ` Jingoo Han
2012-01-19 14:38 ` Archit
2012-01-20 0:52 ` Donghwa Lee
2012-01-23 3:13 ` Archit
2012-01-20 23:51 ` Andrew Morton
2012-01-25 0:14 ` Donghwa Lee [this message]
2012-01-26 15:45 ` Tomi Valkeinen
2012-01-27 1:42 ` Donghwa Lee
2012-01-27 3:06 ` Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1F4982.5050000@samsung.com \
--to=dh09.lee@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox