Subject: [PATCH 07/21] OMAP3+: PM: SR/Class3: disable errorgen before disable VP

From: [email-masked] (Sergei Shtylyov)
Date: Tue, 31 Jan 2012 15:37:08 +0400

Hello.

On 31-01-2012 14:06, Jean Pihet wrote:

> ...

>>> +int sr_disable_errgen(struct voltagedomain *voltdm)
>>> +{
>>> +       u32 errconfig_offs, vpboundint_en;
>>> +       u32 vpboundint_st;
>>> +       struct omap_sr *sr = _sr_lookup(voltdm);
>>> +
>>> +       if (IS_ERR(sr)) {
>>> +               pr_warning("%s: omap_sr struct for sr_%s not found\n",
>>> +                       __func__, voltdm->name);
>>> +               return -EINVAL;
>>
>>
>>    Not PTR_ERR(sr)?

> _sr_lookup returns a return code using ERR_PTR so the return value
> should be checked for errors using IS_ERR. Please note that _sr_lookup
> checks for NULL parameter internally.

    That's clear. I was asking don't you want to return PTR_ERR(sr) instead of 
-EINVAL.

WBR, Sergei