public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: lars@metafoo•de (Lars-Peter Clausen)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 02/10] pwm: Allow chips to support multiple PWMs.
Date: Mon, 06 Feb 2012 22:22:49 +0100	[thread overview]
Message-ID: <4F3044A9.8000202@metafoo.de> (raw)
In-Reply-To: <1328541585-24642-3-git-send-email-thierry.reding@avionic-design.de>

On 02/06/2012 04:19 PM, Thierry Reding wrote:
> This commit modifies the PWM core to support multiple PWMs per struct
> pwm_chip.

I think you should mention what motivates this change.

> It achieves this in a similar way to how gpiolib works, by
> allowing PWM ranges to be requested dynamically (pwm_chip.base == -1) or
> starting at a given offset (pwm_chip.base >= 0).

If we've learned one thing from gpiolib, I think it is that using a global
index to identify a resource was a bad idea.

> A chip specifies how
> many PWMs it controls using the npwm member. Each of the functions in
> the pwm_ops structure gets an additional argument that specified the PWM
> number (it can be converted to a per-chip index by subtracting the
> chip's base).
> 
> The total maximum number of PWM devices is currently fixed to 64, but
> can easily be made configurable via Kconfig.

The code says 1024.

> 
> The patch is incomplete in that it doesn't convert any existing drivers
> that are now broken.

  reply	other threads:[~2012-02-06 21:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-06 15:19 [PATCH v2 00/10] Add PWM framework and device-tree support Thierry Reding
2012-02-06 15:19 ` [PATCH v2 01/10] PWM: add pwm framework support Thierry Reding
2012-02-06 15:19 ` [PATCH v2 02/10] pwm: Allow chips to support multiple PWMs Thierry Reding
2012-02-06 21:22   ` Lars-Peter Clausen [this message]
2012-02-07  7:04     ` Thierry Reding
2012-02-07 11:38       ` Mark Brown
2012-02-08  9:13       ` Russell King - ARM Linux
2012-02-08 11:12         ` Thierry Reding
2012-02-07 22:53   ` Ryan Mallon
2012-02-08  8:15     ` Thierry Reding
2012-02-08  9:00       ` Sascha Hauer
2012-02-08 11:16         ` Thierry Reding
2012-02-08  9:17       ` Russell King - ARM Linux
2012-02-08 10:31         ` Thierry Reding
2012-02-06 15:19 ` [PATCH v2 03/10] of: Add PWM support Thierry Reding
2012-02-06 15:19 ` [PATCH v2 04/10] arm/tegra: Fix PWM clock programming Thierry Reding
2012-02-06 15:19 ` [PATCH v2 05/10] arm/tegra: Provide clock for only one PWM controller Thierry Reding
2012-02-06 15:19 ` [PATCH v2 06/10] pwm: Add NVIDIA Tegra SoC support Thierry Reding
2012-02-06 15:19 ` [PATCH v2 07/10] arm/tegra: Add PWFM controller device tree probing Thierry Reding
2012-02-06 15:19 ` [PATCH v2 08/10] pwm: Add Blackfin support Thierry Reding
2012-02-06 15:19 ` [PATCH v2 09/10] pwm: Add PXA support Thierry Reding
2012-02-06 15:19 ` [PATCH v2 10/10] pwm-backlight: Add rudimentary device tree support Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F3044A9.8000202@metafoo.de \
    --to=lars@metafoo$(echo .)de \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox