From: javi.merino@arm•com (Javi Merino)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: pl330: fix null pointer dereference in pl330_chan_ctrl()
Date: Thu, 09 Feb 2012 10:35:56 +0000 [thread overview]
Message-ID: <4F33A18C.7050409@arm.com> (raw)
In-Reply-To: <000101cce6c4$10a5edb0$31f1c910$%kim@samsung.com>
On 09/02/12 00:44, Boojin Kim wrote:
> Javi Merino wrote:
>
>> On 13/01/12 13:02, Russell King - ARM Linux wrote:
>>> On Fri, Jan 13, 2012 at 12:36:31PM +0000, Mans Rullgard wrote:
>>>> This fixes the thrd->req_running field being accessed before thrd
>>>> is checked for null. The error was introduced in abb959f.
>>>>
>>>> Signed-off-by: Mans Rullgard <mans.rullgard@linaro•org>
>>>
>>> I don't know what's happening with the PL330 driver, but there's patches
>>> around to remove this file and merge it with the DMA engine driver.
>>
>> The PL330 merge didn't happen in the 3.3 merge window and I can't see it
>> in linux-next, so linux 3.3 will ship with the driver still split in
>> arch/arm/common/pl330.c and drivers/dma/pl330.c . I think this patch
>> should be part of linux 3.3 (and you should add "Cc: stable at kernel.org"
>> so that it's included in the next 3.2 stable release).
>>
>> Unless somebody thinks otherwise, Mans, can you please submit it to
>> rmk's patch tracking system?
> I rebased your patch based on pl330 merge commit with kukjin kim. And confirmed to working it well. You can check it on below URL.
> git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git v3.4-for-vkou
Sorry, I wasn't talking about my patch but Mans':
http://article.gmane.org/gmane.linux.linaro.devel/9445
It fixes a null pointer dereference in the current kernel and I still
think it should go into 3.3 and in the next 3.2 stable release. That
will create another conflict in your tree I'm afraid.
Cheers,
Javi
next prev parent reply other threads:[~2012-02-09 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 12:36 [PATCH] ARM: pl330: fix null pointer dereference in pl330_chan_ctrl() Mans Rullgard
2012-01-13 13:02 ` Russell King - ARM Linux
2012-02-08 13:59 ` Javi Merino
2012-02-09 0:44 ` Boojin Kim
2012-02-09 10:35 ` Javi Merino [this message]
2012-01-13 13:48 ` Javi Merino
2012-01-13 19:46 ` Mans Rullgard
2012-01-14 21:53 ` Sergei Shtylyov
2012-01-25 12:11 ` [PATCH] DMA: " Mans Rullgard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F33A18C.7050409@arm.com \
--to=javi.merino@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox